Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344554

Summary: Remove property doesnt works after edit
Product: [Eclipse Project] PDE Reporter: Ankur Sharma <ankur_sharma>
Component: UIAssignee: Ankur Sharma <ankur_sharma>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public
Version: 3.7Flags: ankur_sharma: review+
Target Milestone: 3.7 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
Improved Fix none

Description Ankur Sharma CLA 2011-05-03 07:35:40 EDT
I20110428-0848

1. Create a Product Configuration and goto Configuration page
2. Click Add button and add a property
3. Select the entry and click Edit button. Change the property name. Click OK
4. Now click the Remove button. The entry will not delete.
Comment 1 Ankur Sharma CLA 2011-05-05 06:56:36 EDT
Created attachment 194813 [details]
patch

Curtis, consider it for RC1
Comment 2 Curtis Windatt CLA 2011-05-05 16:14:38 EDT
-1 when editing the item is removed from the tree which is confusing and then the selection is lost.  I will attach a better patch.
Comment 3 Curtis Windatt CLA 2011-05-05 16:17:38 EDT
Created attachment 194879 [details]
Improved Fix
Comment 4 Curtis Windatt CLA 2011-05-05 16:20:50 EDT
Ankur, please review the updated patch.  Only problem I see is the blink caused by removing/adding the item during table refresh.  A better solution would require redesigning how the properties are stored in the product.
Comment 5 Ankur Sharma CLA 2011-05-09 11:19:48 EDT
+1

Applied to HEAD
Comment 6 Curtis Windatt CLA 2011-05-16 16:46:36 EDT
Verified in I20110514-0800