Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344544

Summary: Javadoc for method type parameters should not be generated if 'Ignore method type parameters' is disabled
Product: [Eclipse Project] JDT Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: deepakazad, some-eclipse-user-84964571335246229170
Version: 3.7Flags: daniel_megert: review+
Target Milestone: 3.7 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix
none
Fix 2
none
Test updates
none
Complete Patch with Tests daniel_megert: review+

Description Dani Megert CLA 2011-05-03 05:46:38 EDT 
3.7 M7.

The Javadoc generation for 'Add all missing tags' quick fix and 'Generate Element Comment' (Alt+Shift+J) should not add the tags for type parameters if 'Ignore method type parameters' is disabled (default).
Comment 1 Markus Keller CLA 2011-05-10 12:45:21 EDT 
Created attachment 195246 [details]
Fix

The 'Ignore method type parameters' is new in 3.7. It would make sense to fully support this and avoid generating unwanted tags.
Comment 2 Markus Keller CLA 2011-05-10 12:51:12 EDT 
Created attachment 195247 [details]
Fix 2

First patch was incomplete.
Comment 3 Markus Keller CLA 2011-05-10 12:51:38 EDT 
Dani, OK for RC1?
Comment 4 Markus Keller CLA 2011-05-10 16:08:30 EDT 
Created attachment 195271 [details]
Test updates
Comment 5 Markus Keller CLA 2011-05-11 06:20:18 EDT 
Created attachment 195321 [details]
Complete Patch with Tests

The patch with the test updates was not complete. Here's the complete all-in-one. Code changes are the same as in Fix 2.
Comment 6 Dani Megert CLA 2011-05-11 06:40:03 EDT 
+1 for RC1.
Comment 7 Markus Keller CLA 2011-05-11 07:06:45 EDT 
Fixed in HEAD.
Comment 8 Deepak Azad CLA 2011-05-16 02:29:56 EDT 
Verified with I20110512-2000.
Comment 9 Dani Megert CLA 2019-01-31 13:01:24 EST 
*** Bug 543183 has been marked as a duplicate of this bug. ***