Bugzilla – Full Text Bug Listing
| Summary: | Contributing a Helgrind plugin for Linux Tools Project | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Daniel Henrique Barboza <danielhb> | ||||
| Component: | Valgrind | Assignee: | Elliott Baron <ebaron> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | overholt, wainersm | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 0.8.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 346455, 348269, 354223 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Henrique Barboza
Created attachment 194525 [details]
Tarball with the source code of Helgrind plugin
Tarball with the source code of Helgrind plugin
Thanks for the contribution, Daniel! I've opened a contribution questionnaire [1] with the Eclipse legal team: http://dev.eclipse.org/ipzilla/show_bug.cgi?id=5116 (Only existing committers will be able to see the contents of that URL) I'm confident that they're going to ask that you state that you authored 100% of the code and if not we'll need contact details for each of the contributors: name, organization, email address and/or phone number, percent of contribution authored. IBM being a member organization makes this easier. [1] http://wiki.eclipse.org/Development_Resources/New_Commmitter_Handbook#Contribution_Questionnaire_.28CQ.29 Fantastic! I'll be glad to help in any way I can. Just to double-check: I need to wait for the contact of the Eclipse Legal team and answer their questions, right? Are they going to contact by email? (In reply to comment #4) > Just to double-check: I need to wait for the contact of the Eclipse Legal team > and answer their questions, right? Are they going to contact by email? That is correct. Thanks, Daniel. Hi Daniel, Sharon from the Eclipse legal team has requested a statement from you (on this bug) confirming that you: 1. authored 100% of the content I am contributing 2. have the rights to contribute the content to Eclipse 3. contribute the content under the project license (EPL in this case) Also, if anyone other than yourself wrote any of the code, they'll need to put a similar statement here. Thanks. I, Daniel Henrique Barboza, assert that I am the author of 100% of the code I am contributing, I have the rights to contribute this content to Eclipse and that such content is being contributed under the terms of EPL. Thanks, Daniel. The awesome Sharon of the Eclipse Legal team has managed to squeeze this in and has said "This submission is approved!" We can now commit this to the repository. Elliott, did you want to commit it or shall I? (In reply to comment #8) > Thanks, Daniel. The awesome Sharon of the Eclipse Legal team has managed to > squeeze this in and has said "This submission is approved!" We can now commit > this to the repository. > > Elliott, did you want to commit it or shall I? Great! I'll commit it. (In reply to comment #9) > (In reply to comment #8) > > Thanks, Daniel. The awesome Sharon of the Eclipse Legal team has managed to > > squeeze this in and has said "This submission is approved!" We can now commit > > this to the repository. > > > > Elliott, did you want to commit it or shall I? > > Great! I'll commit it. I have checked the code in and added the Helgrind plugin to the Valgrind feature. Thanks Daniel! Andrew, this plugin needs a pom file for Tycho, correct? Is it just a matter of copying from another plugin and doing some renaming? (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > Thanks, Daniel. The awesome Sharon of the Eclipse Legal team has managed to > > > squeeze this in and has said "This submission is approved!" We can now commit > > > this to the repository. > > > > > > Elliott, did you want to commit it or shall I? > > > > Great! I'll commit it. > > I have checked the code in and added the Helgrind plugin to the Valgrind > feature. > Thanks Daniel! > > Andrew, this plugin needs a pom file for Tycho, correct? Is it just a matter of > copying from another plugin and doing some renaming? Copying from another plugin and doing renaming is easiest. You can then add it to valgrind/pom.xml. Thanks for taking care of this checkin, Elliott. I created the POM file and added the module entry to the parent POM file. I'll mark this resolved, feel free to reopen if we're not done. Thanks, Elliott. I see the build from yesterday includes the plugin jar so it looks like everything went well. I created bug #345863 to track creating some unit tests. Hi Andrew, Just to double check: helgrind plug-in will not be include in Linux Tools 0.8? (In reply to comment #14) > Hi Andrew, > > Just to double check: helgrind plug-in will not be include in Linux Tools 0.8? Actually, now that it's been approved by the legal team, we can get it in. Is there a reason it should not be included? (In reply to comment #15) > (In reply to comment #14) > > Hi Andrew, > > > > Just to double check: helgrind plug-in will not be include in Linux Tools 0.8? > > Actually, now that it's been approved by the legal team, we can get it in. Is > there a reason it should not be included? No, absolutely not. Actually I'd like to consume it through Linux Tools 0.8. Please, go ahead to get it in. Thanks for all your support. Daniel, Could you please write up a few sentences and take a screenshot or two for use in our new and noteworthy for 0.8? You can see examples of other such entries here: http://www.eclipse.org/linuxtools/new/ Thanks, Andrew Is Helgrind plugin going live on 0.8 already? This is AWESOME! Great news indeed! @ Andrew I'm on it *** Bug 273876 has been marked as a duplicate of this bug. *** |