Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344489

Summary: NPE in PlatformUiUtil.supportsMultipleHyperlinkPresenter causing bugzilla to fail to load and error dialog
Product: z_Archived Reporter: Shawn Minto <shawn.minto>
Component: MylynAssignee: Shawn Minto <shawn.minto>
Status: RESOLVED FIXED QA Contact: Frank Becker <eclipse>
Severity: normal    
Priority: P3 CC: robert.elves
Version: unspecified   
Target Milestone: 3.6   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
patch
eclipse: iplog+
patch V2
none
mylyn/context/zip
none
patch V3
none
mylyn/context/zip none

Description Shawn Minto CLA 2011-05-02 13:01:18 EDT 
When the org.eclipse.platform bundle is not included with an RCP product on MAC, users are unable to use the bugzilla connector due to an NPE in the constructor.

Caused by: java.lang.NullPointerException
	at org.eclipse.mylyn.internal.provisional.commons.ui.PlatformUiUtil.supportsMultipleHyperlinkPresenter(PlatformUiUtil.java:145)
	at org.eclipse.mylyn.internal.bugzilla.ui.tasklist.BugzillaConnectorUi.<init>(BugzillaConnectorUi.java:73)
Comment 1 Shawn Minto CLA 2011-05-02 13:02:24 EDT 
Created attachment 194512 [details]
patch

Here is a potential patch to the commons project
Comment 2 Frank Becker CLA 2011-05-02 14:03:09 EDT 
Created attachment 194519 [details]
patch V2

Shawn,

can you please verify my changes.

I think it is better to assume that the MultipleHyperlinkPresenter is not present.
Comment 3 Frank Becker CLA 2011-05-02 14:03:11 EDT 
Created attachment 194520 [details]
mylyn/context/zip
Comment 4 Shawn Minto CLA 2011-05-03 19:26:46 EDT 
That looks good to me.
Comment 5 Frank Becker CLA 2011-05-04 14:03:21 EDT 
patch V2 is now in HEAD
Comment 6 Steffen Pingel CLA 2011-05-04 18:07:05 EDT 
Which is the bundle that provides the multiple hyper link support? We should check the version of that exact bundle if it's not the org.eclipse.platform bundle.
Comment 7 Frank Becker CLA 2011-05-05 16:56:24 EDT 
Created attachment 194883 [details]
patch V3

(In reply to comment #6)
> Which is the bundle that provides the multiple hyper link support? We should
> check the version of that exact bundle if it's not the org.eclipse.platform
> bundle.

Please see bug# 322293 . The bundle is org.eclipse.swt but I did not know what version of org.eclipse.swt was used in eclipse platform 3.7.0.v201101192000. When I look in the cvs repository I think that this is v3721. Can someone verify this? 

the actual eclipse platform version   3.7.0.v201103101119 use swt 3.7.0.v3724c
Comment 8 Frank Becker CLA 2011-05-05 16:56:27 EDT 
Created attachment 194884 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2011-05-05 17:15:19 EDT 
That's fine with me. Seems most important that we properly differentiate recognize <= 3.6.2 and >= 3.7 here.

Please change the TODO comment to the standard format so we can find it when approriate: //TODO e3.7 change this to.... Otherwise please feel free to commit.
Comment 10 Frank Becker CLA 2011-05-06 14:36:19 EDT 
patch V3 is now in head. See comment#9