Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344465

Summary:

[Table Editor] Papyrus should provide Facets and Queries to edit the element stereotyped with SysML

Product:

[Modeling] Papyrus

Reporter:

Vincent Lorenzo <vincent.lorenzo>

Component:

Core

Assignee:

Vincent Lorenzo <vincent.lorenzo>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

yann.tanguy

Version:

0.7.0

Target Milestone:

0.8.0

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

334240

Attachments:

Description	Flags
Patch 1/2	vincent.lorenzo: review+
Patch (2/2)	vincent.lorenzo: review+

Description Vincent Lorenzo

2011-05-02 10:45:16 EDT

The new tables allow to create FacetColumn in order to display and edit the properties for stereotyped elements.
Papyrus should provides Facet and Queries to edit the SysML Stereotypes in the table.

Comment 1 Vincent Lorenzo

2011-05-02 10:48:24 EDT

Committed in R4596 : 
   the facets and queries for the SysML Requirement

Comment 2 Vincent Lorenzo

2011-05-02 10:50:11 EDT

Committed in R4598 : minor change in oep.sysml (adds some String in SysmlResource.java)

Comment 3 Vincent Lorenzo

2011-05-02 11:47:51 EDT

In R4604 : correct redefinedBy into refinedBy

Comment 4 Yann Tanguy

2011-06-22 10:46:37 EDT

Created attachment 198408 [details]
Patch 1/2

Comment 5 Yann Tanguy

2011-06-22 10:47:21 EDT

Created attachment 198409 [details]
Patch (2/2)

Comment 6 Yann Tanguy

2011-06-22 10:49:32 EDT

String ID are not necessary for property management, take advantage of static profile by using the EMF API.
Can you review the attached patches before I commit ?

Comment 7 Vincent Lorenzo

2011-06-23 05:03:38 EDT

Comment on attachment 198408 [details]
Patch 1/2

I agree for these changes, but I think that the other SysML facets will be generated and not hand written. I'm not sure that the future generator provides these enhancements.

Comment 8 Vincent Lorenzo

2011-06-23 05:03:53 EDT

Comment on attachment 198409 [details]
Patch (2/2)

Ok for me.

Comment 9 Yann Tanguy

2011-06-23 05:45:23 EDT

(In reply to comment #7)
> I agree for these changes, but I think that the other SysML facets will be
> generated and not hand written. I'm not sure that the future generator provides
> these enhancements.

Well, it should :), maybe two generator are needed 1 for dynamic profile and another for static profile...
Who is currently working on this generator ?

Also, currently "VerifiedBy" contains stereotyped Operation(s) but from the specification point of view, a Requirement can be verified by "TestCase" which can be Operation or Behavior, how is this currently handle by the table editor framework ? Is it possible to hold different kind of EObject in a cell ?
As a replacement, would it be possible to locate "TestCase" stereotype application EObject directly in the cell and provide a specific label provider for these element (giving the name of the underlying stereotype NamedElement). Doing this would be closer to the metamodel implementation (showing any kind of TestCase in a cell), and would simplify the query implementation (1 single implementation for all using EMF API would probably be sufficient then).

Comment 10 Yann Tanguy

2011-06-23 05:58:25 EDT

Patch applied in r4858.

Comment 11 Vincent Lorenzo

2011-06-23 07:30:39 EDT

(In reply to comment #9)

Camille and I are working on the generator.

It's not a problem to have different kind of EObject in the same cell. But your query should returns the 
a common ancestor of Operation and Behavior.

The framework doesn't allow to modify the label provider, but you can write a uiCustom file on EObject to get the correct label for the StereotypeApplication.

Comment 12 Yann Tanguy

2011-06-29 05:57:35 EDT

(In reply to comment #10)
> Patch applied in r4858.
Merge into trunk (r4910).

Comment 13 Vincent Lorenzo

2013-02-07 04:24:28 EST

This bug can be marked as closed fixed. Now we provided the full Facet Model for SysML profile