Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344446

Summary:

[Intro] BIDI: BDL_Welcome page is not mirrored

Product:

[Eclipse Project] Platform

Reporter:

amir <bamir>

Component:

User Assistance

Assignee:

Chris Austin <ChrisAustin>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

camle, cgold, ChrisAustin, daniel_megert, prakash, pwebster

Version:

3.7

Flags:

cgold: review+

Target Milestone:

3.7 RC1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Welcome page is not mirrored	none
Patch to fix welcome rtl text	none

Description amir

2011-05-02 08:58:19 EDT

Build Identifier: I20110310-1119

Welcome page is not mirrored when eclipse GUI is mirrored

Reproducible: Always

Steps to Reproduce:
When launch eclipse with -rtl option welcome page is not mirrored.
In addition, navigation arrows in toolbar are not mirrored

Comment 1 amir

2011-05-02 09:00:12 EDT

Created attachment 194481 [details]
Welcome page is not mirrored

Comment 2 Chris Goldthorpe

2011-05-06 13:30:18 EDT

Chris A, can you look into this, it may to be related to the change you made to Eclipse 3.7 for RTL.

Comment 3 Chris Austin

2011-05-09 17:00:49 EDT

Created attachment 195149 [details]
Patch to fix welcome rtl text

Yes - I noticed this in the backpatch for 3.6.2, but didn't catch it in 3.7.  The attached patch should take care of it.  Amir, can you confirm that this patch resolves the welcome rtl issue?  Note, this does not change the back/forward buttons - I think those are supposed to be as they are in the screenshot.

Comment 4 Chris Goldthorpe

2011-05-09 17:45:13 EDT

Targeting RC1 - please add me as a reviewer if you think this patch is ready to commit.

Comment 5 Chris Goldthorpe

2011-05-10 13:07:55 EDT

Patch is good but needed the copyright changed to 2011. I have updated the copyright and applied the patch.

Comment 6 Chris Goldthorpe

2011-05-16 13:22:08 EDT

Verified in : I20110512-2000.