Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344436

Summary:

[imports on paste] Allow to cancel 'Update imports on paste'

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Text

Assignee:

Dani Megert <daniel_megert>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, markus.kell.r, raksha.vasisht, remy.suen

Version:

3.7

Flags:

markus.kell.r: review+

Target Milestone:

3.7 RC1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix	none

Description Dani Megert

2011-05-02 07:20:10 EDT

3.7 M7.

Adding imports on paste can result in a search when it tries to resolve on-demand conflicts. When the search index is still built this results in a blocked UI, see e.g. bug 343837.

Comment 1 Dani Megert

2011-05-04 03:43:54 EDT

Created attachment 194670 [details]
Fix

Comment 2 Dani Megert

2011-05-04 03:44:59 EDT

Markus, please review the patch. +1 for RC1?

Comment 3 Markus Keller

2011-05-05 05:28:32 EDT

Fix is good. However, I would use getSite().getService(..) instead of getAdapter(..), as recommended by IWorkbenchSiteProgressService.

Comment 4 Dani Megert

2011-05-05 05:53:59 EDT

Committed my patch to HEAD.

Comment 5 Raksha Vasisht

2011-05-16 06:58:59 EDT

Verified for 3.7RC1 with  I20110514-0800.