Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344386

Summary: IRepositoryChangeListener does not receive CREDENTIALS events from the task repository dialog
Product: z_Archived Reporter: Robert Munteanu <robert.munteanu>
Component: MylynAssignee: Project Inbox <mylyn-triaged>
Status: CLOSED MOVED QA Contact:
Severity: normal    
Priority: P2    
Version: 3.5   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Robert Munteanu CLA 2011-04-30 18:16:16 EDT
The only location which fires this event is the TaskRepositoryLocationUi$PasswordRunner. The task repository dialog should also fire this change event when the username and/or password change.
Comment 1 Steffen Pingel CLA 2011-08-11 09:10:44 EDT
Robert, would you be able to provide a patch to fix this?
Comment 2 Robert Munteanu CLA 2011-08-11 16:23:51 EDT
I might find the time, but I will only be able to look into it in September.
Comment 3 Robert Munteanu CLA 2011-09-30 14:51:19 EDT
Ideally these listeners would be notified by the TaskRepository itself. However, since the listeners are registered in the ui plugin, we can't do that. I see two possibilities:

# create a TaskRepositoryCredentialsChangeListener class which can be registered to the TaskRepository and have the TasksUiPlugin register a listener which is notified of credentials changes. In turn, these credential changes would be propagated to listeners of the TaskRepositoryManager
# add the change logic in the AbstractRepositorySettings.apply

No matter what the approach is, the events should only be fired if the credentials changed. The taskRepository should return a boolean from the setter if the credentials changed.

What do you think?
Comment 4 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn