Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344349

Summary: [breakpoints] Breakpoint delete undo doesn't work when multi-select group and breakpoints.
Product: [Eclipse Project] Platform Reporter: Pawel Piech <pawel.1.piech>
Component: DebugAssignee: Paul Pazderski <paul-eclipse>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: paul-eclipse, sarika.sinha
Version: 3.7   
Target Milestone: 4.12 M3   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/142041
https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=3b426f81e380107a9a1e4bbf46407ac9924de12b
Whiteboard:

Description Pawel Piech CLA 2011-04-29 16:47:52 EDT 
Build id: I20110425-1800

To reproduce: 
- Create some breakpoints.
- In the breakpoints view selected "Group by -> Breakpoint Type".  
- Select all breakpoints and groups (Ctrl-A)
- Delete with delete key shortcut.  
- A dialog pops up asking "do you want to delete all breakpoints in group".  Select "Yes".
- Select Edit-Undo... nothing happens.

I think that the multi-select of group and breakpoints causes the bug.  If either the breakpoints or groups are selected, the undo works.
Comment 1 Eclipse Genie CLA 2019-05-12 08:14:31 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Paul Pazderski CLA 2019-05-12 08:39:42 EDT 
Still reproducible with 4.11 and I20190510-1800.
Comment 3 Paul Pazderski CLA 2019-05-12 13:41:52 EDT 
The error arise from breakpoints being deleted twice if group and element in group is selected.

org.eclipse.core.runtime.CoreException: Exception while deleting breakpoint markers
	at org.eclipse.debug.ui.DebugUITools.deleteBreakpoints(DebugUITools.java:352)
	at org.eclipse.debug.internal.ui.actions.breakpoints.RemoveBreakpointAction$1$1.run(RemoveBreakpointAction.java:135)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.eclipse.core.commands.ExecutionException: Error while executing the "Delete Breakpoints" operation
	at org.eclipse.ui.ide.undo.AbstractWorkspaceOperation.execute(AbstractWorkspaceOperation.java:202)
	at org.eclipse.core.commands.operations.DefaultOperationHistory.execute(DefaultOperationHistory.java:495)
	at org.eclipse.debug.ui.DebugUITools.deleteBreakpoints(DebugUITools.java:350)
	... 2 more
Caused by: org.eclipse.core.internal.resources.ResourceException: Marker id 48 not found.
	at org.eclipse.core.internal.resources.Marker.checkInfo(Marker.java:63)
	at org.eclipse.core.internal.resources.Marker.getType(Marker.java:214)
	at org.eclipse.ui.internal.ide.undo.MarkerDescription.<init>(MarkerDescription.java:48)
	at org.eclipse.ui.ide.undo.AbstractMarkersOperation.deleteMarkers(AbstractMarkersOperation.java:116)
	at org.eclipse.ui.ide.undo.DeleteMarkersOperation.doExecute(DeleteMarkersOperation.java:62)
	at org.eclipse.ui.ide.undo.AbstractWorkspaceOperation.lambda$0(AbstractWorkspaceOperation.java:200)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2295)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2322)
	at org.eclipse.ui.ide.undo.AbstractWorkspaceOperation.execute(AbstractWorkspaceOperation.java:200)
	... 4 more
Comment 4 Eclipse Genie CLA 2019-05-12 14:53:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/142041
Comment 6 Sarika Sinha CLA 2019-05-21 04:43:29 EDT 
Verified using Build id: I20190520-1805.