Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344274

Summary: SWT BOT fail on Hudson
Product: z_Archived Reporter: Nicolas Guyomar <nicolas.guyomar>
Component: EMF-FacetAssignee: Nicolas Bros <nicolas.bros>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: emft.facet-inbox, gdupe, nicolas.bros
Version: unspecifiedFlags: gdupe: indigo+
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch for Bug 344274 nicolas.bros: iplog+

Description Nicolas Guyomar CLA 2011-04-29 09:36:40 EDT
Hi,

There are 7 tests from org.eclipse.emf.facet.widgets.nattable.tests.swtbot.TableEditabilityTest in failure on Hudson.

I suspect that the use of Display.post(event) method might not be this appropriate one to simulate user interaction on a server.

Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2011-04-29 09:47:16 EDT
Created attachment 194356 [details]
Patch for Bug 344274

Hi,

Please find attached what I hope will solve the problem on Hudson.
Instead of using Display events to notify the table that a double click has occurred, I now send directly the correct event to the widget, which should have been the solution in the first place.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Nicolas Bros CLA 2011-04-29 09:55:52 EDT
Comment on attachment 194356 [details]
Patch for Bug 344274

I've committed this patch in revision 593.

This is a contribution from an employee of Mia-Software, targeting a future
Indigo release. Since the company has signed a Member Committer Agreement, the
contribution does not need a CQ (see bug 322327).
Comment 3 Nicolas Bros CLA 2011-04-29 11:05:02 EDT
Note: the tests are still failing on Hudson with this patch.
Comment 4 Gregoire Dupe CLA 2011-05-20 10:27:18 EDT
Today, the unit test from TableEditabilityTest run properly:  https://hudson.eclipse.org/hudson/job/emffacet-nightly/341/testReport/org.eclipse.emf.facet.widgets.nattable.tests.swtbot/TableEditabilityTest/

The bug can then be closed.