Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344246

Summary: illegal API use in org.eclipse.emf.facet.infra.query.ui.wizards.NewQueryClassWizardPage
Product: z_Archived Reporter: Nicolas Bros <nicolas.bros>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: Ed.Merks, emft.facet-inbox, gdupe
Version: unspecifiedFlags: gdupe: indigo+
Ed.Merks: pmc_approved+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for Bug 344246 gdupe: iplog+, gdupe: review+

Description Nicolas Bros CLA 2011-04-29 05:00:35 EDT 
NewQueryClassWizardPage extends org.eclipse.jdt.ui.wizards.NewClassWizardPage, which is marked "@noextend"
Comment 1 Nicolas Guyomar CLA 2011-06-06 11:03:48 EDT 
Created attachment 197404 [details]
Patch for Bug 344246

Hi,

Please find attached an simpler wizardPage implementation for EMF Facet Java
query creation.


(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-08-22 08:56:04 EDT 
Hello Ed,

Here is a patch fixing the illegal use of org.eclipse.jdt.ui.wizards.NewClassWizardPage by a EMF Facet 0.1 component. 

Cf. http://download.eclipse.org/facet/downloads/drops/0.1.0/R201106070516/api_report/html/org.eclipse.jdt.ui%20%283.7.0%29/org.eclipse.jdt.ui.wizards.NewClassWizardPage.html

Do you agree to apply this patch in the service release?

Regards,
Gregoire
Comment 3 Gregoire Dupe CLA 2011-08-31 04:12:06 EDT 
Comment on attachment 197404 [details]
Patch for Bug 344246

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution in the branch 0.1.

Committed revision 801.
Comment 4 Gregoire Dupe CLA 2011-08-31 05:37:17 EDT 
Comment on attachment 197404 [details]
Patch for Bug 344246

(In reply to comment #3)

> I've committed this contribution in the branch 0.1.
> Committed revision 801.

The revision 801 was a commit on the trunk.

I've committed in the branch 0_1 in the revision 804.
Comment 5 Gregoire Dupe CLA 2011-08-31 05:37:46 EDT 
This bug can be mark as resolved.
Comment 6 Gregoire Dupe CLA 2012-05-22 10:14:40 EDT 
This bug can be closed.
Comment 7 Gregoire Dupe CLA 2012-05-23 06:45:21 EDT 
(In reply to comment #6)
> This bug can be closed.

So I close this bug.