Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344243

Summary: illegal API use in org.eclipse.gmt.modisco.infra.query.ui.wizards.NewQueryClassWizardPage
Product: [Modeling] MoDisco Reporter: Nicolas Bros <nicolas.bros>
Component: InfrastructureAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: gdupe, hugo.bruneliere, Kenn.Hussey, modisco.web-inbox
Version: 0.9.0Flags: gdupe: indigo+
Kenn.Hussey: pmc_approved+
Target Milestone: 0.9.1 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for Bug 344243 gdupe: iplog+, gdupe: review+

Description Nicolas Bros CLA 2011-04-29 04:48:33 EDT 
org.eclipse.gmt.modisco.infra.query.ui.wizards.NewQueryClassWizardPage extends org.eclipse.jdt.ui.wizards.NewClassWizardPage, which is marked "@noextend This class is not intended to be subclassed by clients."
Comment 1 Nicolas Guyomar CLA 2011-06-06 11:00:31 EDT 
Created attachment 197402 [details]
Patch for Bug 344243

Hi,

Please find attached an simpler wizardPage implementation for MoDisco Java query creation.


(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-08-22 08:28:26 EDT 
Comment on attachment 197402 [details]
Patch for Bug 344243

I had to applied manually this patch, but it works fine.
Comment 3 Gregoire Dupe CLA 2011-08-22 08:45:35 EDT 
(In reply to comment #2)
> Comment on attachment 197402 [details]
> Patch for Bug 344243
> 
> I had to applied manually this patch, but it works fine.

Sorry, I made a mistake: there is no difficulties to apply this patch.
Comment 4 Gregoire Dupe CLA 2011-08-22 08:47:29 EDT 
Hello Kenn,

Here is a patch fixing the illegal use of org.eclipse.jdt.ui.wizards.NewClassWizardPage by a MoDisco 0.9 component. 

Cf.
http://download.eclipse.org/modeling/mdt/modisco/downloads/drops/0.9.0/R201106080421/api_report/html/org.eclipse.jdt.ui%20%283.7.0%29/org.eclipse.jdt.ui.wizards.NewClassWizardPage.html

Do you agree to apply this patch in the service release?

Regards,
Gregoire
Comment 5 Gregoire Dupe CLA 2011-08-22 10:08:05 EDT 
Comment on attachment 197402 [details]
Patch for Bug 344243

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution:
 - in the trunk (Committed revision 4531)
 - in the branch 0.9 (Committed revision 4532)
Comment 6 Gregoire Dupe CLA 2011-08-22 10:10:02 EDT 
This bug can be marked has resolved.
Comment 7 Hugo Bruneliere CLA 2012-05-29 08:29:10 EDT 
Already solved.