Bugzilla – Full Text Bug Listing
| Summary: | Extract Function: Improvements to the dialog | ||
|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Markus Schorn <mschorn.eclipse> |
| Component: | cdt-refactoring | Assignee: | Sergey Prigogin <eclipse.sprigogin> |
| Status: | RESOLVED FIXED | QA Contact: | Sergey Prigogin <eclipse.sprigogin> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | cdtdoug, mober.at+eclipse, yevshif |
| Version: | 8.0 | ||
| Target Milestone: | 8.1.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
CQ:WIND00252467 Take a look at the new dialog and let me know how you like it. |
When using the 'Extract Function' refactoring a dialog is shown. I suggest the following improvements: (1) There is a group named 'Return value:', however it primarily deals with the parameters. (2) The option 'No return value (void)' is confusing: When I do not check this option and do not select any of the radio buttons in the 'return' column, I will still get no return value. It looks like the only purpose of the option is to allow for deselecting the radio button in the return column, once it has been selected. --> I suggest to remove this option and let the user deselect a radio button by clicking on it again. (3) For c++ it be nice to have the option to use a pointer type rather than a reference type for arguments passed by-reference. (4) It'd be nice to show a preview of the function declaration.