Bug 344201

Comment 1 Susan McCourt 2011-04-28 16:33:17 EDT

The current search results page simply spews out the results into a div.
It would be interesting to explore a structured search results page where the user could group by originating file, look at file hierarchy, sort, filter, whatever...

Eclipse search is a good place to start looking for ideas.

This isn't critical for the June release but is nice separate piece of work that someone could look at.

Comment 2 Mark Macdonald 2011-04-28 17:30:05 EDT

Not sure if this is the right place for this feedback, but... we're using the same search-result layout in the "Open Resource" dialog, and my pet peeves with it are:

 1. You can't disambiguate several files with the same name at a glance.
 2. To open the 2nd or 3rd result in the list, you need to take your hands off the keyboard and actually click the link.


Issue #1 can be fixed by giving more context (eg. file path).
Issue #2 may only interesting to obsessive keyboard users like myself, but it would be very cool to have richer keyboard navigation for the search results. (cf. GitHub's 't' filter, which lets you use the arrow keys). Might be useful on the nav page too.

Comment 3 libing wang 2011-07-20 16:24:20 EDT

As I mentioned at comment 3 in bug 344200 , we will address the search result in a better layout .

Comment 4 libing wang 2011-09-20 17:30:35 EDT

checked in first draft of the global search today.
1.All the results are rendered in a tree structure.
2.All the "local search " result is automatically rendered for the first file.
3. You can expand all(list up all the search result inside each file) or collapse all 
4. If you expand a file first time , the inside file search happens once.

5. next and prev search result navigation is in the  middle (algorithm is ready, just the UI part)but my plan is to put it in tomorrow.

Comment 5 libing wang 2011-09-21 16:51:13 EDT

Final draft checked in with 3f915fc8bd3c4d1d9e2a686407244207e84f5ea5.
Now in the search result page you can :
1.Render the result as a tree and the first file is auto expanded with the first search result highlighted.
2.Clicking on any search result navigates to the editor with that line.
3.You can navigate all results by doing next or previous result action, which will walk you through all the results.(we do not open the editor yet unless you click on a result. Maybe we should figure out a way to preview it: some thing like the inline compare editor? )
4.You can also expand or collapse all the results.
5. Both expand(single or all) or next/prev action will trigger the on-demand in-file search, which is a one-time action.

There are more than a dozen of the global search entries now.
From the openResouceDialog and the "CTRL+H" inside Orion editor, I am still using flat list to render the result. Other than that, all the entries will render a tree view.

I am closing this bug now , if any one finds any thing to be fixed/enhanced, please open a new bug and assign to me directly.