Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344192

Summary:

[import/export] Polish comments for p2 import/export

Product:

[Eclipse Project] Equinox

Reporter:

John Arthorne <john.arthorne>

Component:

Assignee:

Meng Xin Zhu <kane.zhu>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

bernhard.merkle, daniel_megert, pascal, pwebster, tjwatson

Version:

unspecified

Keywords:

polish

Target Milestone:

3.7 RC1

Flags:

daniel_megert: review+

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
pls review the spelling and grammar	none
add mnemonics	kane.zhu: review?

Description John Arthorne

2011-04-28 15:49:21 EDT

I tried out the p2 import/export and have a few comments on minor things (mostly labels and messages):

- The category name for the import/export operations is "p2". I think this is very unintuitive from an end user perspective. We don't use the term "p2" or even "eclipse" or "equinox" anywhere else in the UI because these are technical terms that are only meaningful to an eclipse insider. I suggest "Install" as the category name (consistent with preference category), or even possibly "General" category. 

- p2 also appears in a label in the export wizard. In that context I think it could just be "To export file"

- The description text for the two import commands seems to be backwards. The description for "From existing installation" says, "Install a set of software from the local file system.". The description for "Install Software items from file" says "Install a batch of software from another eclipse instance." I think they should be reversed.

- Menu item names should be capitalized [1]. So they should be "Install Software From File System", "Install Software From Existing Application", etc.

- The "existing installation" wizard uses the term, "existing Eclipse installation" in both the title description and as a field label. The user might be using a branded product so "Eclipse" won't always make sense. I suggest something more generic like "Install from another application" or similar.


[1] http://wiki.eclipse.org/User_Interface_Guidelines#Capitalization_2

Comment 1 Dani Megert

2011-05-02 08:49:10 EDT

I just saw this bug. I also filed bug 344444 which could probably be marked as duplicate but which should really be addressed before 3.7 ships.

Comment 2 Matthew Piggott

2011-05-02 09:31:04 EDT

*** Bug 344444 has been marked as a duplicate of this bug. ***

Comment 3 Paul Webster

2011-05-02 13:02:29 EDT

Just a comment:  In preferences, the category is Install/Update.

PW

Comment 4 Dani Megert

2011-05-03 01:43:53 EDT

(In reply to comment #3)
> Just a comment:  In preferences, the category is Install/Update.
> 
> PW

Would also be OK for me.

Comment 5 Pascal Rapicault

2011-05-03 23:02:29 EDT

Paul, Dani, what about simply putting these entries under the General category?

Comment 6 Dani Megert

2011-05-04 03:21:14 EDT

(In reply to comment #5)
> Paul, Dani, what about simply putting these entries under the General
> category?
I don't think it fits nicely into the 'General' category. I'd prefer 'Install' but could also live with 'Install/Update'.

Comment 7 John Arthorne

2011-05-04 09:14:11 EDT

I thought the "General" category was a possibility, since the Preference import is the other import that modifies my install rather than my workspace. But now that I think about it more, it will be unexpected that an "Import" operation would install new software (rather than put a plugin in my workspace), so anything we can do to reduce that surprise would be helpful. So, I think an "Install" category name would help users learn that this is something quite different from the workspace installs in other categories.

Comment 8 Meng Xin Zhu

2011-05-05 07:15:11 EDT

*** Bug 344497 has been marked as a duplicate of this bug. ***

Comment 9 Pascal Rapicault

2011-05-05 15:21:26 EDT

I've released the change to rename to "Install"

Comment 10 Pascal Rapicault

2011-05-05 15:56:15 EDT

All the issues are now fixed.

Comment 11 Dani Megert

2011-05-06 02:04:26 EDT

Verified in N20110505-2000.

Comment 12 Meng Xin Zhu

2011-05-06 02:52:49 EDT

I still see 'p2' and 'eclipse' appear in the import/export wizard dialog, do we need remove or rename them?

Comment 13 Dani Megert

2011-05-06 03:02:06 EDT

(In reply to comment #12)
> I still see 'p2' and 'eclipse' appear in the import/export wizard dialog, do we
> need remove or rename them?

You probably used the I-build and not the latest N-build.

Comment 14 Dani Megert

2011-05-06 03:03:53 EDT

Sorry, I see now: the category is fixed but on the wizards itself the wording has not yet been changed.

Comment 15 Pascal Rapicault

2011-05-09 13:20:30 EDT

Everything is up-to-date for me in I20110507-0800

Comment 16 Dani Megert

2011-05-10 02:37:16 EDT

Sorry to nag ;-)

In I20110507-0800, if you select any of the Install wizards and click 'Next', they all still use the term "p2" which we don't use in the UI (see comment 0). At least the bold page title of Import > 'From Existing Installation' should be be changed - currently it says "p2 Import".

Also, all UI strings are missing mnemonics.

Comment 17 Meng Xin Zhu

2011-05-10 02:41:55 EDT

Created attachment 195173 [details]
pls review the spelling and grammar

1. remove the words 'eclipse', 'p2' in the export/import wizard itself
2. consolidate the naming

Comment 18 Meng Xin Zhu

2011-05-10 02:55:07 EDT

Created attachment 195174 [details]
add mnemonics

Comment 19 Pascal Rapicault

2011-05-10 08:24:01 EDT

I've applied this last patch and it looks good. At least from my point of view :)

Comment 20 Pascal Rapicault

2011-05-10 08:32:41 EDT

Closing

Comment 21 Dani Megert

2011-05-16 10:14:21 EDT

Looks good now in I20110512-2000 :-).