Bugzilla – Full Text Bug Listing
| Summary: | [Compatibility] Not all emacs keybindings override default keybindings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Paul Webster <pwebster> | ||||||
| Component: | UI | Assignee: | Michael Rennie <Michael_Rennie> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, jessev, ob1.eclipse, pwebster, remy.suen, steffen.pingel, vainolo | ||||||
| Version: | 4.1 | Flags: | ob1.eclipse:
review+
|
||||||
| Target Milestone: | 4.2 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Paul Webster
Created attachment 194412 [details]
Work in progress: key overrides when switching schemes
WORK IN PROGRESS:
This will do a check to make sure that if there's a conflict between two bindings of difference schemes, then the binding with the "youngest" scheme will override the other.
There's still that issue with BindingService.getPerfectMatch(Binding) where it won't find bindings with certain contexts, so only 1/4 conflicts get overridden when switching to emacs (CTRL+Y).
Also, when switching back to the default scheme, the previously overridden bindings won't become re-enabled for some reason. I'm not too sure why this is right now, but if you got re-open the prefs page again, you can restore it or reset defaults and it will become active again.
Anyway, hopefully this is a good starting point.
- Jesse
This also means that the key binding hints in the menus are wrong sometimes: e.g. Ctrl+F is indicated for Edit > Find/Replace... but it doesn't work. Created attachment 195613 [details]
Work out scheme overrides v02
When saving pref page changes, pick the most correct binding based on scheme and type (system vs user) so there's no conflict.
PW
Released PW Tried on 4.1 build: I20110515-0800: it still shows 'Ctrl+F' for Edit > Find/Replace after switching to 'Emacs' scheme. M2 is done... Aggregate move to M5. Retarget to a different milestone if you wish... I'm still having trouble with the binding Alt+W to Copy. On e4 (I20120315-1300) this activates the Windows menu item from the global menu bar instead of pasting text. On 3.x the mnemonic for the Window menu item is automatically unbound. Start with org.eclipse.e4.ui.keybinding.tests.BindingPersistenceTest.testPasteAndRedoBindingEmacs() to figure out why we get no CTRL+Y binding in the emacs config. PW (In reply to comment #9) > Start with > org.eclipse.e4.ui.keybinding.tests.BindingPersistenceTest.testPasteAndRedoBindingEmacs() > to figure out why we get no CTRL+Y binding in the emacs config. OK, figured that out. It works correctly on windows, linux has a delete marker for CTRL+Y PW (In reply to comment #8) > I'm still having trouble with the binding Alt+W to Copy. On e4 (I20120315-1300) > this activates the Windows menu item from the global menu bar instead of > pasting text. On 3.x the mnemonic for the Window menu item is automatically > unbound. pwebster/bug344181 contains a fix for this usecase. PW Oleg, I need a +1 for this bug. (In reply to comment #1) > Also, when switching back to the default scheme, the previously overridden > bindings won't become re-enabled for some reason. I'm not too sure why this is > right now, but if you got re-open the prefs page again, you can restore it or > reset defaults and it will become active again. I'm working on this in bug 375762 PW (In reply to comment #12) > Oleg, I need a +1 for this bug. Sure. It still shows 'Ctrl+F' for Edit > Find/Replace after switching to 'Emacs' scheme, using 4.2 M7, and nothing happens when pressing Ctrl+F. I'm continuing my work on those bindings in bug 375762 PW |