Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344170

Summary: [Validation] The class of struct converter is not validated against the right interface
Product: [WebTools] Dali JPA Tools Reporter: Nan Li <nan.n.li>
Component: GeneralAssignee: Leslie Davis <les.davis>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: david_williams, jolene.moffitt, neil.hauge
Version: unspecifiedFlags: david_williams: pmc_approved+
neil.hauge: pmc_approved? (raghunathan.srinivasan)
neil.hauge: pmc_approved? (naci.dai)
neil.hauge: pmc_approved? (deboer)
neil.hauge: pmc_approved? (neil.hauge)
neil.hauge: pmc_approved? (kaloyan)
neil.hauge: pmc_approved? (cbridgha)
neil.hauge: review+
Target Milestone: 3.0 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard: PMC_approved
Attachments:
Description Flags
proposed bug fix patch neil.hauge: iplog+

Description Nan Li CLA 2011-04-28 13:55:18 EDT 
Build Identifier: I-3.3.0-20110414020027

Currently, the class of strcut converter is validated against the EclipseLink org.eclipse.persistence.mappings.converters.Converter interface; however, the right interface should be the EclipseLink org.eclipse.persistence.platform.database.converters.StructConverter interface based on the source code for @StructConverter and what works the runtime. The wiki is incorrect about this, but we do give the right class name in the class "EclipseLinkStructConverter".

Reproducible: Always
Comment 1 Leslie Davis CLA 2011-05-03 17:20:34 EDT 
Created attachment 194653 [details]
proposed bug fix patch
Comment 2 Neil Hauge CLA 2011-05-03 17:51:35 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This bug results in invalid validation errors on StructConverters

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround for this error.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Ad-hoc testing done by Les and myself.

    * Give a brief technical overview. Who has reviewed this fix? 

I have reviewed the fix.  This is a simple addition of validation specific to StructConverters where as before these were being validated as general Converters.

    * What is the risk associated with this fix? 
Low risk fix.
Comment 3 Neil Hauge CLA 2011-05-10 11:36:49 EDT 
Patch committed.
Comment 4 Neil Hauge CLA 2011-05-10 11:39:07 EDT 
.
Comment 5 Jolene Moffitt CLA 2011-06-02 12:56:09 EDT 
Verified in Build I-3.3.0RC2-20110520234832

Verified validation for struct converter appears.  To view test steps for verification.  http://wiki.eclipse.org/Dali_3.0_RC1