Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344145

Summary: [EMF Runtime Extensions] AbstractModelConverter should build document from XMLInputSource with systemId and publicId set
Product: [Automotive] Sphinx Reporter: Loïc Quéran <loic.queran>
Component: CoreAssignee: Stephan Eberle <stephaneberle9>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: 0.7.0   
Target Milestone: 0.7.0   
Hardware: All   
OS: All   
Whiteboard:

Description Loïc Quéran CLA 2011-04-28 11:25:20 EDT 
If this is not the case, XMLSchemaValidator uses the user directory as the base to normalize hints.

In ARTOP tests, the XSD schema is searched in <testplugin>/working-dir if converters are used.
Comment 1 Stephan Eberle CLA 2011-04-29 03:15:57 EDT 
Sounds reasonable, but I need to better understand how exactly you want this to be done.

First of all, with XMLInputSource, do you mean org.apache.xerces.xni.parser.XMLInputSource or org.xml.sax.InputSource? I imagine that the latter is the case given that org.jdom.input.SAXBuilder#build() methods accept only InputSource but not XMLInputSource.

Second, from where and how should the publicId and systemId parameters be initialized? Should they be calculated in any way or should application be enabled to initialized them via setter methods?
Comment 2 Loïc Quéran CLA 2011-05-02 02:57:09 EDT 
(In reply to comment #1)
> Sounds reasonable, but I need to better understand how exactly you want this to
> be done.
> 
> First of all, with XMLInputSource, do you mean
> org.apache.xerces.xni.parser.XMLInputSource or org.xml.sax.InputSource? I
> imagine that the latter is the case given that
> org.jdom.input.SAXBuilder#build() methods accept only InputSource but not
> XMLInputSource.

Yes, sorry, org.xml.sax.InputSource
> 
> Second, from where and how should the publicId and systemId parameters be
> initialized? Should they be calculated in any way or should application be
> enabled to initialized them via setter methods?


if (resource.getURI() != null) {
			String resourceURI = resource.getURI().toString();
			inputSource.setPublicId(resourceURI);
			inputSource.setSystemId(resourceURI);
                        ...
		}
See ExtendedXMLLoadImpl line 122.
In XMLSchemaValidator line 2522, the fXSDDescription.setBaseSystemId(fLocator.getExpandedSystemId()) must set the base system to a value that makes it possible to find the XSD.
Comment 3 Stephan Eberle CLA 2011-05-02 16:23:38 EDT 
Fixed in AbstractModelConverter#doConvertLoad() as proposed in comment #2. Feel free to reopen if not appropriate.
Comment 4 Balazs Grill CLA 2021-07-14 02:14:55 EDT 
Mass-closing Resolved tickets