Bugzilla – Full Text Bug Listing
| Summary: | decorate gerrit tasks with review icon | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Benjamin Muskalla <b.muskalla> | ||||||||
| Component: | Mylyn | Assignee: | Mik Kersten <mik.kersten> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | steffen.pingel | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | 0.9 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Benjamin Muskalla
We have been very careful with vendor branding in the UI. Generally, we only show that for repositories. Agreed though that we should have a review specific task decoration. I think it makes sense to use a generic "review task" decorator across all review implementations. Created attachment 195545 [details]
icon
How about this? ;)
Not a bad idea. I like it better than the glasses that we have been using elsewhere but it might be hard to distinguish from the standard decoration for stories. I'll bring it up on the next Mylyn call. We discussed this on the call today and had some concerns that the decoration is too ambiguous. The conclusion was to try an eyeglass decoration as an alternative. Created attachment 199633 [details]
three sizes of the standard glasses icon
Thanks Mik. I'll add that as a decoration. Could you post the result? Created attachment 199872 [details]
screenshot
Not bad. Kinda hard to see that they are glasses, but at least it's a standard Eclipse icon. Yes, it's not easy to recognize the glasses but it's distinguishes review tasks well and it's easy to remember once you have learned the icon. As per the review on today's call I'll mark this bug as resolved. I never would have guessed that those were glasses. It seems kind of pointless to use a "standard" icon if it's unrecognizable. Maybe a magnifying glass would be easier to see? |