Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344101

Summary: [implementation] out-of-sync handling: keeping Eclipse editor content should dirty the editor
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: TextAssignee: Dani Megert <daniel_megert>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: daniel_megert, ishaikovsky, jamesblackburn+eclipse, markus.kell.r
Version: 1.0   
Target Milestone: 3.8 M7   
Hardware: All   
OS: All   
Whiteboard:

Description Dani Megert CLA 2011-04-28 06:06:23 EDT
When a file is out-of-sync we show a dialog where the user can choose whether to keep the current Eclipse editor content or replace it with the content from the file system. If the Eclipse editor content is kept then we don't dirty the editor and also don't change the file on the file system.

Problems:
1. When closing the editor we don't notify the user and the Eclipse content is 
   lost.
2. When reopening the file we tell the user again that the file is not in sync.

==> We should synchronize the file and then paste the Eclipse editor content into it so that it gets dirty.
Comment 1 Dani Megert CLA 2011-04-28 08:23:21 EDT
Like that since 1.0!
Comment 2 Dani Megert CLA 2011-04-28 08:58:22 EDT
*** Bug 123598 has been marked as a duplicate of this bug. ***
Comment 3 Dani Megert CLA 2012-04-03 08:35:05 EDT
I've fixed the data loss bug (1.) which is really what this bug is all about.  

Fixed in master: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5719618e550ebc69298a1fbbf203d534a846a193
Comment 4 Dani Megert CLA 2012-04-30 04:54:21 EDT
Verified in I20120429-2000.