Bugzilla – Full Text Bug Listing
| Summary: | Allow adding all files to context | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Benjamin Muskalla <b.muskalla> | ||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | robert.munteanu, steffen.pingel, voelzmo | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Muskalla
Makes sense. This is related to bug 339777 which provides similar functionality for Java stack traces. Created attachment 199005 [details]
draft patch
Here is a draft for such a feature (do not commit!): On activation of the review task, it adds all files to the current context.
Pain points:
* We currently add all files from all patchsets to the context. While maybe only the files of the last patchset are interesting, the context should maybe now more then only the latest patch set.
* Context get's populated on review task activation. Thinking about adding a link to each patchset to manually enhance the context with a specific patchset (would also solve first item)
Outlook:
* Parse down to the diff-level to provide more fine-grained context informations about methods, etc.
Would love to get some feedback/comments on this.
Created attachment 199006 [details]
mylyn/context/zip
I like this approach. We could try to refine it and actually add the Java elements that were changed and not just the files but that would require access to the actual contents. I wonder if we should couple this to fetching of patch sets. That could be a common work-flow: Open review, select patch set, fetch and activate. We could then show the annotations inline in editors and allow adding new comments for files that are part of the review. What do you think? Great work Benny! I thought this would be a nice thing to do, but then I see that you've already done it! I wonder if you could package it into a Gerrit review so we can take a closer look? One of the things that the Reviews Explorer work provides is a natural way to cue the user to fetch a particular patch set. .. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |