| Summary: | [Compatibility] Action bars must be deactivated when its parent part gets disposed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | DJ Houghton <dj.houghton> | ||||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | remy.suen | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 4.1 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=379142 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
DJ Houghton
Created attachment 194210 [details]
log file
That's a little hard to read... here's the log file as an attachment.
Since the trim is destroyed _after_ the window's children are, I'm surprised to find that this is a problem. Will have to investigate further... This is consistent and I can reproduce locally if you want to see/connect. (In reply to comment #3) > This is consistent and I can reproduce locally if you want to see/connect. I've reproduced it on my end so this won't be necessary. Thanks for the offer of assistance, DJ. :) The basic gist of the story here is to set an image to the status line in your part, then when your part is disposed go and dispose the image too (like the good citizens we are). At this point, you have a disposed image in the status line. Normally, when a part gets deactivated we ask it to deactivate its own action bars and this will clear the status line for us. Unfortunately, when the deactivation event happens in this case, the part itself has already been destroyed so we can't request that it deactivate its action bars. Created attachment 194280 [details]
Action bars deactivation patch v1
We should deactivate the action bars when the part has been disposed.
(In reply to comment #5) > Created attachment 194280 [details] > Action bars deactivation patch v1 Patch released to HEAD. Thanks for the bug report, DJ! |