Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 344029

Summary:	Editor navigation and Tab-Ordering
Product:	[Eclipse Project] Platform	Reporter:	Thomas Schindl <tom.schindl>
Component:	UI	Assignee:	Dean Roberts <dean.t.roberts>
Status:	CLOSED FIXED	QA Contact:	Remy Suen <remy.suen>
Severity:	major
Priority:	P3	CC:	ajpeustace, daniel_megert, dean.t.roberts, ed, emoffatt, Lars.Vogel, loskutov, pwebster, remy.suen, vlad, yoda
Version:	4.1
Target Milestone:	4.2 M6
Hardware:	All
OS:	All
Whiteboard:

Description Thomas Schindl

2011-04-27 15:19:38 EDT

This a major regression in useablility compared to 3.x so i file it as a major bug which IMHO needs to be solved before releasing 4.1.

Take the following scenario:

Shown as tab:
-------------
* Editor A
* Editor B
* Editor C

Shown in chevron:
-----------------
* Editor D

Now if you navigate from Editor A to Editor D (e.g. using F3, ...) Editor A goes into the chevron and the shown tabs are:

Shown as tab:
-------------
* Editor B
* Editor C
* Editor D

Shown in chevron:
-----------------
* Editor A

But it should be:

Shown as tab:
-------------
* Editor A
* Editor B
* Editor D

Shown in chevron:
-----------------
* Editor C (or better said the one with oldest activation timestamp)

Comment 1 Thomas Schindl

2011-04-28 02:14:37 EDT

bug 68684 request no MRU while i request here to get MRU back so maybe we could have a preference option for this?

Comment 2 Vlad Berditchevskiy

2011-04-28 03:42:47 EDT

It's good news that this weird MRU behavior is not present any more. ;-) If you decide to get MRU back, please do not hard code it, but use a preference instead! For people, who rely on visual order and frequently use Ctrl+PgUp/Ctrl+PgDown, MRU is a nightmare.

Comment 3 Remy Suen

2011-12-21 19:31:35 EST

*** Bug 367277 has been marked as a duplicate of this bug. ***

Comment 4 Ed Willink

2011-12-22 01:34:33 EST

And the files shown in the chevron pop-up is not in alphabetical order.

And the files shown in the chevron does not also show the open files.

Sorry, but since I have a choice, I will not use this. I'm reverting to 3.8M4.

Given the very good compatibility of e4 in general, perhaps this, surely rather simple problem, now merits 'critical' status.

Comment 5 Remy Suen

2012-01-12 09:46:21 EST

(In reply to comment #4)
> And the files shown in the chevron pop-up is not in alphabetical order.
> 
> And the files shown in the chevron does not also show the open files.

As a workaround, you can use Ctrl+E instead. The list is not alphabetical at the moment but has a text field for filtering purposes.

Comment 6 Dean Roberts

2012-01-25 12:29:18 EST

Added ability to turn on 3.8 style MRU behaviour via the CSS file.

Add

mru-visible: true;

to the 

MPartStack 

section of your active CSS theme file.  A workbench restart will be needed if you edit the css file directly.

The code was released in the following commit

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e65ebe90dcf990700855749aa0eceea8dd0c5815

Comment 7 Remy Suen

2012-01-25 12:32:28 EST

(In reply to comment #6)
> A workbench restart will be needed if
> you edit the css file directly.

Like most CSS changes, a 'Window > New Window' should be sufficient in most cases.

1. Edit the file.
2. Go to the 'Appearance' preference page and change the theme.
3. Change the theme back to what you originally had (to force a reload).
4. Window > New Window

Comment 8 Remy Suen

2012-01-26 09:34:36 EST

Verified that MRU mode is turned on when a classic theme is used with I20120125-2200 on Windows 7.

Comment 9 Dani Megert

2012-02-02 09:30:13 EST

See also bug bug 370441.

Comment 10 Ed Willink

2012-02-02 16:35:50 EST

When using classic scheme

a) the visible editors are now in MRU order - fixed thanks
b) the other editors in the chevron are in MRU rather than alphabetical order - not 3.x theme
c) the visible editors are not shown in bold in the chevron - not 3.x theme
d) the background is grey rather than pale buff

At least a) is fixed. Maybe I can stay on 4.2 now, but I'm not sure how I'm supposed to find an entry in a 100 entry non-alphabetic chevron list.

Comment 11 Remy Suen

2012-02-02 16:39:29 EST

(In reply to comment #10)
> At least a) is fixed. Maybe I can stay on 4.2 now, but I'm not sure how I'm
> supposed to find an entry in a 100 entry non-alphabetic chevron list.

Ctrl+E is your best workaround at the moment. See bug 370441.

Comment 12 Dean Roberts

2012-02-24 09:45:17 EST

Rationalized Editor List Ctrl+E and pressing the chevron tool bar button behaviour to open the same list in the same place.  IE as a drop down on the chevron.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b9e09a429fd4b337576cf3fec2946f26ca6ba3c8

Comment 13 Dean Roberts

2012-02-24 11:15:01 EST

Added back dirty indicators in editors list.

Also added hint text to the editors list filter field to give some indication that the user can type filter text.  Since this is implemented using the Text.setMessage() call the hint text will not be visible whenever the text widget has focus.  This means that when the list is first opened the text does not appear.  But will appear if the user begins scrolling the list.

Implementing behaviour like the preferences page filter is, I believe, too heavy weight for the benefit.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=54a02ed6b491f28b25831d516268bffa99b4f657

Comment 14 Dean Roberts

2012-02-28 09:32:43 EST

Marking this as fixed as I believe this is as far as we intend to go with this feature.