| Summary: | [diagram] Node tooltip appears for no reason | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Konstantin Komissarchik <konstantin> |
| Component: | Sapphire | Assignee: | Ling Hao <ling.hao> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Konstantin Komissarchik
Node tooltip is needed for nodes with long labels which don't fit into the space reserved for them. However, For node labels that fit, we don't need to display tooltips for them. I've improved the logic for displaying node tooltips. Tooltips only show up when node labels are too long and when the mouse is over the label. It looks like when you change node label such that you transition from "need tooltip" to "don't need tooltip" (shorten it), then tooltip is not updated. I am guessing that returning null causes tooltip to not be updated in Graphiti model as opposed to cleared. If I am correct and this cannot be fixed without a fix from Graphiti, it would be best to revert the change that went in and defer this to the 0.4 release. Good catch! My logic for calculating tooltips is correct. But there is a Graphiti bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=348662. I have provided a patch for it. Lets wait to see how soon Graphiti team can address this. My past experience is they're pretty quick in resolving bugs when patches are provided or when asked to resolve the bugs ASAP. Unfortunately, Graphiti is even further along in their 0.8 release than we are. They are part of the official Indigo train and are pretty much in lock down mode... Let's wait a couple of days on Graphiti team. Since the patch is a fairly low risk fix, they might take it. If not, I'll revert my fix. Re-opening so that we don't loose track of this. There is no time for applying patch for https://bugs.eclipse.org/bugs/show_bug.cgi?id=348662. I've reverted my change. Will have to wait for Graphiti Indigo SR1 release. This one would be good to take a look at sooner rather than later... If nothing else, it would be nice to get rid of the reopened column in the 0.5 bug report. Add conditional check for tooltip. Much better. Thanks. |