Bugzilla – Full Text Bug Listing
| Summary: | [client] new icons to match visual style | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> | ||||||
| Component: | Client | Assignee: | Susan McCourt <susan> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | bokowski, john.arthorne, libingw, malgorzata.tomczyk, mamacdon, Mike_Wilson, Szymon.Brandys | ||||||
| Version: | 0.2 | ||||||||
| Target Milestone: | 0.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Susan McCourt
Regarding icons. They are useful for the local actions that appear inside the actions column, where space is tight. Also nice to include in the menus. But I'm starting to think that for the page level commands, we should be rendering them all as text links. There are typically only two or three icons at that level anyway, and we want the user to be able to find the common page tasks easily without having to decipher an icon. (In reply to comment #1) > But I'm starting to think that for the page level commands, we should be > rendering them all as text links. mockups posted to bug 344876 I released the "text only commands on the page toolbar" as part of bug 344876. We'll still design icons for some of the commands which also appear in other places, or if we think they might in the future. But we'll prioritize accordingly. This is the list I've sent the graphic designer. If you don't see an icon you need in this list, please annotate this bug. Navigator 1. Add (as in Add favorite, or Add site) 2. "Make Favorite" (star) 3. "Rename" 4. "Download" or "Export" to zip 5. "Delete" 6. "Upload" or "Import" as zip 7. "SFTP Import" (may use generic import and use the menu words to distinguish) 8. "SFTP Export" (may use generic export and use menu words to distinguish) 9. "New File" 10. "New Folder" 11. Checkboxes in checked and unchecked state 12. Tree twisties in three states: closed/collapsed, opening, open/expanded Editor (No icons, only the text "Save" command) Sites (Only existing icons, need to get rid of floppy disk on "Save" button) Plugins 13. Refresh Repositories 14. Link to folder Git Log 15. Tag Git Status Per discussion in bug 336116, I did not ask for icons for actions against the entire commit (commit) or the entire branch (push, pull, fetch, merge, branch). We most likely will use text links for these actions. To my knowledge, none of these appear "in-line" in an items list where we would need a compact representation. So I've only listed the ones that annotate items. 16. Stage all 17. Stage 18. Side by side compare 19. Unstage 20. Unstage all Git Remote 21. Incoming 22. Outgoing (In reply to comment #4) > Git Status > ... So I've only listed the ones that annotate items. Makes sense. Do we need an icon for "replace with latest from branch/HEAD" since this would be a per-file action? (In reply to comment #5) Just added: Sites: 1. Move up 2. Move down (In reply to comment #6) Also, do we want to use icons to represent resources or model objects (eg. a site configuration, a plugin, a service)? I've been using an icon from Eclipse to represent a site config. I added an Icon for Help in the toolbar. I think it looks fine but just mentioning it here for completeness. Added requests for the following: 23. Help Icon 24. Move up in list 25. Move down in list 26. Replace with remote version of file (for git-status) We would need the following icons: 1. Git Clone UI - Repo icon - Branches and Branch icons - Remotes and Remote icons - Tags icon (Tag icon was already requested) 2. Git Checkout operations I think that for adding/removing branches and remotes I can use the same icons we have in the file navigator and the favorites list i.e. '+' and 'x'. I can't see a request for diff icons. Both status and log pages would need icons showing: - modify change - addition change - removing change Szymon, are there CVS icons you are using today? I've been sending the designer the icons we are currently using as a way to guide the effort. (In reply to comment #12) > Szymon, are there CVS icons you are using today? I've been sending the designer > the icons we are currently using as a way to guide the effort. > - modify change > - addition change > - removing change are taken from the git status UI. I don't know where we have them from. > 1. Git Clone UI > - Repo icon > - Branches and Branch icons > - Remotes and Remote icons > - Tags icon (Tag icon was already requested) We could use CVS icons for repo, branch(es) and tag(s). There is no CVS icon for remote(s) though. > 2. Git Checkout operations There is no CVS icon for this operation. I used EGit one. moving styling bugs to RC1 Update on icon status: The first round from the icon designer wasn't impressively different than what we already have. Linda is working with her on establishing a distinctive style that would be noticeably different/improved. It is looking promising. But there is a chance we won't get them all done in time, so our fallback is that icons won't change. A middle ground is that icons that appear on the page (hovering actions, in the lists/trees) get done first and those that appear in menus would not be done. Given this, we need to ensure the proper IP is in place for the icons that don't come from Eclipse Platform. Szymon - you mentioned you took an icon (checkout) from eGit. Are there any other icons you have obtained from a non-Eclipse Platform project?? Re: new(er) git icons. Now that some of the actions have been added to the git remote page, it would seem we need to request icons for push, pull, merge. I took screencaps of the latest UI and sent an updated request to the designer. These are the additional git icons needed. Szymon, please post here if you think I have forgotten anything. 27. Repository 28. Branch (singular) 29. Branches (plural) 30. Remote (singular) 31. Remotes (plural) 32. Checkout 33. Push 34. Fetch 35. Merge 36. Modification 37. Addition 38. Removal (In reply to comment #13) > > - modify change > > - addition change > > - removing change Libing - can you verify where these icons came from? released all new icons. Please everyone check all your pages. I checked the obvious stuff but might not have hit all hovering actions, etc. I tried to delete unused files in this pass also and it's possible that someone is still relying on a file I deleted. I talked to Simon about this and we agreed it's better to push the change and then have everyone check their pages then to try to source code review the name changes first. The testing is more important. Created attachment 198000 [details]
Show Git Log on the Git Repo view
The new icons look very nice. I wonder if we should replace "Show Git Log" on the clone page with an icon too. Otherwise the Git pages look good.
Created attachment 198001 [details]
The clock on the file picker
Was this icon also replaced?
(In reply to comment #18) > Created attachment 198000 [details] > Show Git Log on the Git Repo view > > The new icons look very nice. I wonder if we should replace "Show Git Log" on > the clone page with an icon too. Otherwise the Git pages look good. This has always seemed a bit weird to me, but I think for now just reordering the commands so that the link appears at the end would make it look better. (In reply to comment #19) > Created attachment 198001 [details] > The clock on the file picker > > Was this icon also replaced? No, none of the dojo tree icons were replaced. I'll open a bug for this, as we also have some old school looking icons in the plugin page. |