Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343939

Summary:

DBCS3.7 DBCS characters are corrupted in Files

Product:

[Tools] Target Management

Reporter:

Kentaroh Noji <kennoji>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

bamir, camle, dmcknigh, kitlo, xuanchen

Version:

3.3

Target Milestone:

3.3 RC2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Screen capture of the chracter corruption	none
Good result with Linux RSE server	none
updated dstore_core.jar with change for windows server to assume UTF8	none
patch to assume utf8 encoding on windows server	none
updated patch to also assume utf8 on windows server when receiving	none
updated dstore_core.jar	none
Good result with the patch (screen capture)	none

Description Kentaroh Noji

2011-04-27 05:52:55 EDT

Build Identifier: I20110412-2200

DBCS file names are placed in remote system. When connecting the remote server from Eclipse, the DBCS files in remote server are corrupted. The code page information of remote system property shows system default code page "MS932". As MS932 is Japanese Windows code page, the connection property may be good. I'm not sure Windows' rseserver handles DBCS file names.  

Configuration: 
RSE: 3.3M6

RSEServer: 
OS - Window XP SP3 32Bit, Japanese environment
JDK - J2RE 1.5.0 IBM Windows 32 build pwi32dev-20080315 (SR7)

Eclipse/RSE:
OS - Windows 7 SP1 64Bit, Japanese environment
JDK: java full version "JRE 1.6.0 IBM Windows AMD 64 buildpwa6460sr9fp1-20110208_03 (SR9 FP1)"
Version: 3.7.0, Build id: I20110412-1532
Version 4.1.0, Build id: I20110412-2200

Reproducible: Always

Steps to Reproduce:
1. Start rseserver (daemon.bat) in windows XP. 
2. Open "Remote System Explorer". Window > Open perspective > Remote System Explorer
3. In remote System view, open the context menu, New > Connection.. > Windows
4. Enter hostname, connection name and description, then finish
5. Open "Files".

Comment 1 Kentaroh Noji

2011-05-10 02:56:02 EDT

Created attachment 195175 [details]
Screen capture of the chracter corruption

Here is a screen capture. I'm sorry that I forgot screen capture...

Comment 2 David McKnight

2011-05-10 08:49:33 EDT

The Windows RSE server is rarely used.  Could you see if this is an issue for something more common like the dstore linux RSE sever?

Comment 3 Kentaroh Noji

2011-05-11 02:32:54 EDT

> Could you see if this is an issue for
> something more common like the dstore linux RSE sever?

The problem does not happen with dstore lunux server. It looks that this problem is caused by Windows RSE server only.

Comment 4 Kentaroh Noji

2011-05-11 02:33:46 EDT

Created attachment 195300 [details]
Good result with Linux RSE server

Comment 5 David McKnight

2011-05-11 09:19:27 EDT

Created attachment 195341 [details]
updated dstore_core.jar with change for windows server to assume UTF8

Could you try this on windows using the attached jar?

Comment 6 David McKnight

2011-05-11 09:22:36 EDT

Created attachment 195342 [details]
patch to assume utf8 encoding on windows server

Comment 7 David McKnight

2011-05-11 09:35:07 EDT

Created attachment 195346 [details]
updated patch to also assume utf8 on windows server when receiving

Comment 8 David McKnight

2011-05-11 09:36:11 EDT

Created attachment 195347 [details]
updated dstore_core.jar

Please try this updated jar instead of the one I originally attached.

Comment 9 David McKnight

2011-05-11 09:39:52 EDT

Since the change works for me, I've committed it to cvs.  Please indicate whether this needs to be backported (since this is Windows server only, I'm not sure it's such a big deal).

Comment 10 Kentaroh Noji

2011-05-11 20:41:58 EDT

(In reply to comment #7)
> Created attachment 195346 [details]
> updated patch to also assume utf8 on windows server when receiving

I verified that the patch worked fine for me.

Comment 11 Kentaroh Noji

2011-05-11 20:43:59 EDT

Created attachment 195450 [details]
Good result with the patch (screen capture)

Comment 12 David McKnight

2011-05-12 12:42:28 EDT

*** Bug 342569 has been marked as a duplicate of this bug. ***

Comment 13 Martin Oberhuber

2011-05-23 08:58:50 EDT

This change didn't make M7 but was released for RC2.