Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343915

Summary:	[client] revisit eWebBorderContainer
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, mamacdon
Version:	0.2
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-04-26 17:45:08 EDT

- the name is obsolete (eWeb) and it should explain what it does (BorderContainer with toggling splitter).
- it is fairly specific in how it works.  It toggles the left pane and gives the space to the center pane.  So it's not really a reusable generic BorderContainer.
- maybe dojo has a toggling splitter by now?
- in bug 343912, I had to use a method getSplitter which is marked as deprecated and will be removed in dojo 2.0

This almost feels like it could be implemented as an external helper method that hooks into a BorderContainer in a specific way rather than extending it.

Comment 1 John Arthorne

2011-04-27 14:07:39 EDT

Please keep me in the loop if it gets tossed or rewritten. Because of the derivate work of dojo in that file, there are various legal files that would need cleaning up if this goes away.

Comment 2 Susan McCourt

2011-04-27 16:33:18 EDT

(In reply to comment #1)
> Please keep me in the loop if it gets tossed or rewritten. Because of the
> derivate work of dojo in that file, there are various legal files that would
> need cleaning up if this goes away.

will do.  I think I'd like to see the derivative code go away because it's that kind of copied implementation code that breaks us from dojo release to release.

Comment 3 Susan McCourt

2011-06-06 19:24:46 EDT

see also bug 347308, where we are also hacking our copied version of the dojox.layout.ToggleSplitter.

Comment 4 Susan McCourt

2012-08-14 13:45:04 EDT

We are no longer using this class, though I have not removed it yet.

In addition to the legal files John mentioned, I think we could remove our use toggle splitter from the built dojo and any other build infrastructure (page optimization) associated with this file.

Comment 5 Susan McCourt

2012-08-14 14:11:44 EDT

fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c950298538f189fc97e5576679c09110195dd92d

removed eWebBorderContainer.
removed the special licensing discussion in about.html of client.core
removed the dojo license file and about-files folder
updated bundles/org.eclipse.orion.dojo/layer/layer.js and bundles/org.eclipse.orion.dojo/layer/layer.js to remove the reference to dojox.ToggleSplitter 

Some free cleanup while mucking around in this:

- removed TitlePane from the layer.js files since we don't use it
- removed a rogue "LabeledCheckbox.js" that was in the client.core root