Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343892

Summary:

use content-type icons in attachment table and input

Product:

z_Archived

Reporter:

Kevin Sawicki <kevin>

Component:

Mylyn

Assignee:

Kevin Sawicki <kevin>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

steffen.pingel

Version:

unspecified

Keywords:

contributed, noteworthy

Target Milestone:

3.6

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none
Screenshot of after patch	none
Screenshot of before patch	none
Patch to support content-type icons	steffen.pingel: iplog+
Test Case	none
screenshot	none

Description Kevin Sawicki

2011-04-26 14:38:45 EDT

The attachment table label provider and attachment file editor input don't
support content-type icons for the file types displayed.

For example a file Main.java doesn't have the Java editor icon when present
in the attachments table or when opened in an editor using the
attachment file editor input class.

Comment 1 Kevin Sawicki

2011-04-26 14:42:42 EDT

Created attachment 194087 [details]
Patch

Patch to use editor registry image descriptor in attachments table label provider and return path from attachment file editor input factory which causes icons to be displayed in editor.

Comment 2 Kevin Sawicki

2011-04-26 14:44:29 EDT

Created attachment 194088 [details]
Screenshot of after patch

Comment 3 Kevin Sawicki

2011-04-26 14:45:33 EDT

Created attachment 194089 [details]
Screenshot of before patch

Comment 4 Kevin Sawicki

2011-04-26 15:03:12 EDT

Created attachment 194090 [details]
Patch to support content-type icons

Comment 5 Steffen Pingel

2011-05-07 19:38:45 EDT

Great patch! I have applied it to head.

Comment 6 Steffen Pingel

2011-05-15 15:48:45 EDT

Created attachment 195676 [details]
Test Case

Comment 7 Steffen Pingel

2011-05-15 15:51:13 EDT

Created attachment 195677 [details]
screenshot