Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343875

Summary: autoreconf runs when clicking Advanced button on config page
Product: z_Archived Reporter: Doug Schaefer <cdtdoug>
Component: AutotoolsAssignee: Jeff Johnston <jjohnstn>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 0.8.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Doug Schaefer CLA 2011-04-26 11:46:24 EDT
When creating a new autotools project, I get to the configurations page and click "Advanced Settings..." so I can adjust the Path environment variable on Windows to point at my MinGW install. I see in the console that the autotools plug-in tries to run autoreconf, which fails since I don't have the Path set up yet.

Under the hood, for better or worse (mainly worse), the new project wizard creates the project and the opens the properties dialog up on it to allow you to change any of the settings. It seems that this triggers the autoreconf. That should probably wait until the user has clicked OK on the new project wizard.
Comment 1 Jeff Johnston CLA 2011-04-27 15:10:31 EDT
(In reply to comment #0)
> When creating a new autotools project, I get to the configurations page and
> click "Advanced Settings..." so I can adjust the Path environment variable on
> Windows to point at my MinGW install. I see in the console that the autotools
> plug-in tries to run autoreconf, which fails since I don't have the Path set up
> yet.
> 
> Under the hood, for better or worse (mainly worse), the new project wizard
> creates the project and the opens the properties dialog up on it to allow you
> to change any of the settings. It seems that this triggers the autoreconf. That
> should probably wait until the user has clicked OK on the new project wizard.

There is a check in the CommonBuilder that looks to see if the CDT project is being created.  Adding this check fixed the problem.  I also made the Autotools Configuration builder configurable so that a user can turn off autobuild if desired.
Comment 2 Doug Schaefer CLA 2011-04-28 16:41:49 EDT
Cool. Thanks Jeff!