Bugzilla – Full Text Bug Listing
| Summary: | Add WindowBuilder Core and SWT/RCP to the rcp-package | ||
|---|---|---|---|
| Product: | [Technology] EPP | Reporter: | Mark Russell <mrrussell> |
| Component: | rcp-package | Assignee: | Project Inbox <epp.packager-inbox> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | clayberg, david_williams, ian.skerrett, Lars.Vogel, mknauer, remy.suen, wayne.beaton |
| Version: | 1.4.0 | ||
| Target Milestone: | 1.4.0 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Mark Russell
c Actually, we want to add WB Core plus the SWT/RCP support (e.g., SWT Designer). - What is the additional size that is required by these features and - which feature IDs need to be included? Despite the fact that this would be a good addition to the package, I think that we need to make sure that the package doesn't get too big. Feature ID's: org.eclipse.wb.core.feature org.eclipse.wb.core.ui.feature org.eclipse.wb.doc.user.feature org.eclipse.wb.layout.group.feature org.eclipse.wb.swt.feature org.eclipse.wb.rcp.feature As far as size goes. Do you want the size of the update site or the individual jar files that make up the feature and plugins? (In reply to comment #4) > As far as size goes. Do you want the size of the update site or the individual > jar files that make up the feature and plugins? The RCP/RAP package has a size of about 180 MB which is already pretty large. I am interested in the size that it would have if we add all your features (including all the dependencies that they pull in) to the package. We might want to leave out the docs as they are quite large. They are available on-line in any case, and we could make them a separately installable package. That would drop org.eclipse.wb.doc.user.feature along with the core doc plugin and the SWT doc plugin. Current File Sizes: org.eclipse.wb.core.feature 7.3M org.eclipse.wb.core.ui.feature 128.0K org.eclipse.wb.doc.user.feature 3.8M org.eclipse.wb.layout.group.feature 428.0k org.eclipse.wb.swt.feature 718.0k org.eclipse.wb.rcp.feature 1.8M total ~= 14.4M update on the sizes: Current File Sizes: org.eclipse.wb.core.feature 7.3M org.eclipse.wb.core.ui.feature 128.0K org.eclipse.wb.layout.group.feature 428.0k org.eclipse.wb.swt.feature 718.0k org.eclipse.wb.rcp.feature 1.8M total ~= 10.3 This is the list of features that need to be added to get WindowBuilder into the rpc-pakage (In reply to comment #8) > update on the sizes: > Current File Sizes: > org.eclipse.wb.core.feature 7.3M > org.eclipse.wb.core.ui.feature 128.0K > org.eclipse.wb.layout.group.feature 428.0k > org.eclipse.wb.swt.feature 718.0k > org.eclipse.wb.rcp.feature 1.8M > > total ~= 10.3 Do I need to get anything more for this to happen for the Indigo release? Markus, Are you okay with adding WindowBuilder to the RAP/RCP package? I would really like to see it added. I think the fact WindowBuilder is now open source will be a big deal for our community, so having it in some of the packages will make it easier for users to adopt it. We will add it to the Java package for the release in June, then we can think about adding it to the RCP/RAP package later, maybe with SR1. I would like to add WindowBuilder to the RCP/RAP package at some point in the future, but as of now the RCP/RAP package is already way too large. We could further reduce the footprint by eliminating the following piece...
org.eclipse.wb.layout.group.feature 428KB
That would bring it in under 10MB
(In reply to comment #13) > We could further reduce the footprint by eliminating the following piece... > > org.eclipse.wb.layout.group.feature 428KB > > That would bring it in under 10MB If this feature--as the name suggests--is support for GroupLayout, then I vote -1 on removing it. Having support for this out of the box is one of the killer features IMHO. Note that this support for (Swing) GroupLayout under SWT/RCP which I think is very much optional (and of questionable value relative to things like SWT GridLayout and FormLayout). GroupLayout support is part of the proposed Swing Designer pieces proposed for the Java Developers package. :-) (In reply to comment #15) > Note that this support for (Swing) GroupLayout under SWT/RCP which I think is > very much optional (and of questionable value relative to things like SWT > GridLayout and FormLayout). GroupLayout support is part of the proposed Swing > Designer pieces proposed for the Java Developers package. :-) I thought of that shortly after I clicked the "Save Changes" button. I'm inclined to still want it included. However, as long as it can be easily added via the "Install New Software..." option, I'm happy. (In reply to comment #16) > I thought of that shortly after I clicked the "Save Changes" button. I'm > inclined to still want it included. However, as long as it can be easily added > via the "Install New Software..." option, I'm happy. Yes...it is part of the WB update site so it is easy to load it as needed (but not impose it on everyone). Was any progress made for shrinking the size of this Distro and adding WB for SR1? *** Bug 370167 has been marked as a duplicate of this bug. *** I'll put it on my list for this year's Juno release. That would be great :-) +1 :-) +1 make Eclipse RCP much easier. I hope that WB will also add support for Eclipse 4 application. Lars - yes, that is the plan. In fact, we will probably use the template you provided ;-) Great news Eric! I integrated WindowBuilder yesterday, but had to remove (disable) it today again because the required features disappeared in the Juno staging repository. Just let me know when they are available again and I will re-enable them in the package. There is an issue with WindowBuilder in the aggrogator build. I'm working on it. Any update on this? Would be really nice to have WB included in the RCP download. The WindowBuilder issue was resolved for M6 and should be fine now. @Marc: Is there a way to test this? Do we have M6 RCP downloads available? (In reply to comment #29) > The WindowBuilder issue was resolved for M6 and should be fine now. That's good to hear. In that case I'll include it in the next scheduled milestone of the RCP/RAP package (M7). (In reply to comment #30) > @Marc: Is there a way to test this? Do we have M6 RCP downloads available? You could try it with the M6 RCP/RAP package download (http://www.eclipse.org/downloads/index-developer.php) and install it manually from the Juno p2 repository if WB is included there (I didn't check this). @Markus: Thanks, I wanted to test if WB is included in the download. ;-) I guess I have to wait for M7 in this case. (In reply to comment #32) > @Markus: Thanks, I wanted to test if WB is included in the download. ;-) I > guess I have to wait for M7 in this case. Yep, that is right... I should have updated this bug earlier... it is included in all builds >=M7 but unfortunately there are two other bugs (bug 380713 and bug 380675) still open. I hope they can be fixed with RC3 this week. They should be fixed now (In reply to comment #34) > They should be fixed now Thanks! I see 1.5.0.r42x201206... WB features now in /releases/staging. This version is now included in the latest nightly package builds >=20120605-0048 at http://build.eclipse.org/technology/epp/epp_build/juno/download/ It would be good to get some testing from your side. :) I did some smoke testing of WB in both the latest Java and RCP builds under both Windows and OSX and it worked great! For Juno this is the case, closing as fixed. |