Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343867

Summary: EvaluationContextManager unnecessarily triggers loading of org.eclipse.cdt.debug.ui
Product: [Tools] CDT Reporter: Pawel Piech <pawel.1.piech>
Component: cdt-debug-dsfAssignee: Pawel Piech <pawel.1.piech>
Status: RESOLVED FIXED QA Contact: Pawel Piech <pawel.1.piech>
Severity: normal    
Priority: P3 CC: cdtdoug, marc.khouzam, mober.at+eclipse
Version: 7.0.2Flags: marc.khouzam: review+
Target Milestone: 8.0   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch with simple fix. cdtdoug: iplog-

Description Pawel Piech CLA 2011-04-26 11:10:47 EDT 
The EvaluationContextManager, which is used to activate several actions in the UI, references org.eclipse.cdt.debug.ui in the following statement:

	private final static String DEBUGGER_ACTIVE = CDebugUIPlugin.getUniqueIdentifier() + ".debuggerActive"; //$NON-NLS-1$


This triggers activating the org.eclipse.cdt.debug.ui plugin as soon as the dsf.ui plugin is activated.  This dependency is not necessary.
Comment 1 Pawel Piech CLA 2011-04-26 12:06:26 EDT 
Created attachment 194072 [details]
Patch with simple fix.
Comment 2 Pawel Piech CLA 2011-04-26 12:18:55 EDT 
I committed the change.  Marc, please review.
Comment 3 CDT Genie CLA 2011-04-26 12:23:15 EDT 
*** cdt cvs genie on behalf of ppiech ***
Bug 343867 - EvaluationContextManager unnecessarily triggers loading of org.eclipse.cdt.debug.ui

[*] EvaluationContextManager.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/EvaluationContextManager.java?root=Tools_Project&r1=1.1&r2=1.2
Comment 4 Marc Khouzam CLA 2011-04-26 13:18:19 EDT 
Nice catch!
Comment 5 Marc Khouzam CLA 2011-05-03 10:11:42 EDT 
Pawel, should we mark this as fixed?
Comment 6 Pawel Piech CLA 2011-05-06 16:11:15 EDT 
(In reply to comment #5)
> Pawel, should we mark this as fixed?

Yes, My bad.