Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343811

Summary: EMF Facet Regression : Created elements in a table are not serialized
Product: z_Archived Reporter: Nicolas Guyomar <nicolas.guyomar>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: emft.facet-inbox, gdupe
Version: unspecifiedFlags: gdupe: indigo+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for Bug 343811 (Non regression test)
none
New plug-in : org.eclipse.emf.facet.tests.util.swtbot
gdupe: iplog+
Patch for Bug 343811 (Non regression test) gdupe: iplog+

Description Nicolas Guyomar CLA 2011-04-26 05:41:48 EDT
Hi,

Step to reproduce the regression:
- Open a table using the "Open Ecore Tabular Editor"
- Create some instance of EClass using the "Create new element" button
- Save the .table
- Open the .table, elements are not there, nor are they in the ecore file

Regards,
Nicolas Guyomar
Comment 1 Gregoire Dupe CLA 2011-04-26 08:39:43 EDT
Hello,

I've fixed this bug. (Committed revision 577.)

A non-regression test is still missing.

Regards,
Gregoire Dupe
Comment 2 Nicolas Guyomar CLA 2011-04-26 11:07:14 EDT
Created attachment 194067 [details]
Patch for Bug 343811 (Non regression test)

Hi,

Please find attached a non regression test for this problem.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 3 Nicolas Guyomar CLA 2011-04-27 04:34:35 EDT
Created attachment 194131 [details]
New plug-in : org.eclipse.emf.facet.tests.util.swtbot

Hi,

Please find attached a new plug-in dedicated to centralized useful util method for swtBot testing.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 4 Nicolas Guyomar CLA 2011-04-27 04:36:02 EDT
Created attachment 194132 [details]
Patch for Bug 343811 (Non regression test)

Hi,

Please find attached an updated version of the non regression test which uses the new plug-in org.eclipse.emf.facet.tests.util.swtbot

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 5 Gregoire Dupe CLA 2011-04-27 11:57:14 EDT
Comment on attachment 194131 [details]
New plug-in : org.eclipse.emf.facet.tests.util.swtbot

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 588.
Comment 6 Gregoire Dupe CLA 2011-04-27 11:58:51 EDT
Comment on attachment 194132 [details]
Patch for Bug 343811 (Non regression test)

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 589.
Comment 7 Gregoire Dupe CLA 2011-04-27 11:59:11 EDT
This bug can be marked as fixed.
Comment 8 Gregoire Dupe CLA 2011-06-07 13:21:52 EDT
This bug can be closed.