Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343808

Summary:	JSF Core judge a jsf project based on jst.jsf facet
Product:	[WebTools] Java Server Faces	Reporter:	Jack Liu <ljfeng1002>
Component:	Core	Assignee:	JSF Project Core <jsf.core-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	raghunathan.srinivasan, thatnitind
Version:	3.2.2
Target Milestone:	Future
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Jack Liu

2011-04-26 05:19:57 EDT

Build Identifier: 201101021000

When digging into the code:
XMLViewDefnAdapter adapter = DTAppManagerUtil.getXMLViewDefnAdapter(context);

It will return null, even the project had all the jsf jar dependency and configuration but without being installed by jst.jsf facet.

It will restrict the usage of jst.jsf tool, if user did not create project from jst.jsf facet.

do we have another way to make the judgement? such as jsf project nature or ...?

Reproducible: Always

Comment 1 Raghunathan Srinivasan

2011-04-27 01:19:05 EDT

Yes, we currently use the jsf facet to make this determination and most of features require the JSF facet.

Comment 2 Jack Liu

2011-04-27 03:10:20 EDT

Do we have any other alternative ways in the future.
One issue is that:
With this API, caller can not get adapter (XMLViewDefnAdapter ) for a jsp file if the project had no jst.jsf facet.

Since jst.jsf depends on jst.jsp, could there be an enhancement to wrap a XMLViewDefnAdapter for jsp in pure DWP? then user won't care more about the project facet (jst.jsf), anyway jst.jsf facet is only a way to help user create and configure DWP.

Please correct me if misunderstanding.

Comment 3 Raghunathan Srinivasan

2011-04-29 18:50:24 EDT

From your description it looks like you want to use JSF tags in a JSP page with out the need fro JSF tooling features.Can you provide a use case of how this code affects a end user feature?

Comment 4 Jack Liu

2011-05-02 22:12:17 EDT

OH, It is bad for a blurred background description.
The story is that:
1. Originally, we create some jsp taglib to wrap UI component and resource operation.
2. We had editor side support.
3. Trying adopting JSF, and wrap original tags into JSF component.
4. We are trying to support the same editor features in html editor for these special tags.

Since the tag usage is same (like <xx.tag xx = "xx" xx = "${xx}">), so we plan to support jsp and xhtml editor with one single implementation, but I found it was strange to fetch el expression between jsp and xhtml.

It is not common for my case, I can accept fetching el and other element by different API.

But in my opinion, facet is only used to create and configure a faceted project. 
like, I create faceted project with java support, I will support java related features based on java nature instead of java facet.
Also I create a project and add jsf dependency and configuration, then I hope I can access jsf related tooling features, it is confusing when I was told that I must install jst.jsf facet.
So I am curious about if there would be a jsf nature there instead of the dependency of jst.jsf facet.

And thanks for your reply :)