Bug 343801

Comment 1 Christoph Brill 2011-04-26 05:41:33 EDT

Created attachment 194039 [details]
LsRemoteCommand.java

Initial attempt at implementing ls-remote.

It seems to work but filtering for tags does not work. It seems like a bug in FetchProcess where the "Set<Ref> matched" is filled but never used. Or maybe I'm doing it wrong?

My simple test program is:

Repository repo = new FileRepository("jgit/.git");
LsRemoteCommand lsRemoteCommand = new LsRemoteCommand(repo);
lsRemoteCommand.setTags(true);
FetchResult call = lsRemoteCommand.call();
for (Ref s : call.getAdvertisedRefs()) {
	System.out.println(s);
}

Comment 2 Christoph Brill 2011-05-04 08:10:33 EDT

Created attachment 194699 [details]
LsRemoteCommand.java

Working implementation

Comment 3 Christoph Brill 2011-05-04 08:12:07 EDT

Created attachment 194700 [details]
LsRemoteResult.java

Necessary return object

Comment 4 Chris Aniszczyk 2011-05-04 08:12:52 EDT

Can you contribute these two patches via Gerrit?

http://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches

Comment 5 Chris Aniszczyk 2011-05-04 08:13:21 EDT

Generally tests are helpful too.

Comment 6 Chris Aniszczyk 2011-05-05 16:14:44 EDT

I pushed a patch here:

http://egit.eclipse.org/r/3346

Please review it if it meets your needs.

Comment 7 Chris Aniszczyk 2011-05-19 15:47:09 EDT

merged into master as e170c314fb96977650d69f7af206d84a362126be.

Also added a LsRemoteCommandTest.

Thanks for your contribution Christoph!