Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343780

Summary:

Infinite recursive call in Zookeeper DiscoveryActivator

Product:

[RT] ECF

Reporter:

Ajay <ajay.upadhyaya>

Component:

ecf.discovery

Assignee:

Wim Jongman <wim.jongman>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ahmed.aadel, bugs.eclipse.org, slewis, wim.jongman

Version:

unspecified

Target Milestone:

3.5.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
mylyn/context/zip	none

Description Ajay

2011-04-25 19:29:32 EDT

Build Identifier: 1.0.100.v20110313-1843

See line 78: removedService(reference, service)


75: public void removedService(ServiceReference reference,
76:		Object service) {
77:     Logger.unbindLogService((LogService) service);
78:     removedService(reference, service);
79:     super.removedService(reference, service); 
80: }

This leads to a StackOverflowError

java.lang.StackOverflowError
	at org.eclipse.ecf.provider.zookeeper.util.Logger.unbindLogService(Logger.java:34)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:77)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
	at org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)

Reproducible: Always

Comment 1 Ajay

2011-04-25 19:30:31 EDT

in plugin:
org.eclipse.ecf.provider.zookeeper_1.0.100.v20110313-1843

Comment 2 Scott Lewis

2011-04-25 20:01:11 EDT

Thanks Ajay for the report.

Adding Markus, Wim, and Ahmed for comment.

Comment 3 Ahmed Aadel

2011-04-26 04:14:47 EDT

misplaced and uneeded recursive line:
78:     removedService(reference, service);
It should, simply, be dropped. 

(In reply to comment #0)
> Build Identifier: 1.0.100.v20110313-1843
> See line 78: removedService(reference, service)
> 75: public void removedService(ServiceReference reference,
> 76:        Object service) {
> 77:     Logger.unbindLogService((LogService) service);
> 78:     removedService(reference, service);
> 79:     super.removedService(reference, service); 
> 80: }
> This leads to a StackOverflowError
> java.lang.StackOverflowError
>     at
> org.eclipse.ecf.provider.zookeeper.util.Logger.unbindLogService(Logger.java:34)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:77)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
>     at
> org.eclipse.ecf.provider.zookeeper.DiscoveryActivator$2.removedService(DiscoveryActivator.java:78)
> Reproducible: Always

Comment 4 Wim Jongman

2011-04-27 17:52:22 EDT

Fixed and released to master. Thank you for reporting this.

Comment 5 Wim Jongman

2011-04-27 17:52:23 EDT

Created attachment 194217 [details]
mylyn/context/zip