Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343773

Summary: [EditorMgmt] Editor history does not work when an external editor is used
Product: [Eclipse Project] Platform Reporter: Prakash Rangaraj <prakash>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, daniel_megert
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard: stalebug
Bug Depends on: 257515    
Bug Blocks:    
Attachments:
Description Flags
Patch v01
none
Patch v02 daniel_megert: review-

Description Prakash Rangaraj CLA 2011-04-25 16:25:04 EDT 
(1) Right click a file->Open With->Other->some external editor.
(2) File->select the file that you just opened
(3) You get an error message: Problems opening the editor 

We shouldn't be showing up the item in the editor history if the file is opened in an external editor
Comment 1 Prakash Rangaraj CLA 2011-04-27 02:48:10 EDT 
Created attachment 194122 [details]
Patch v01

Possible Fix
Comment 2 Prakash Rangaraj CLA 2011-04-27 02:51:38 EDT 
Boris,

      This is one of the usecases for Bug#117746. Should we push this for M7?
Comment 3 Boris Bokowski CLA 2011-04-27 09:24:58 EDT 
I was able to reproduce this, but the following does not lead to an error:

1. Right-click a file, Open With>System Editor (opens with an external editor)
2. File>1 to select the file again
-> opens the file with the external editor.

Would the patch preserve this behaviour, or would Open With>System Editor no longer be in the list of recently opened files?
Comment 4 Prakash Rangaraj CLA 2011-04-29 05:24:10 EDT 
Created attachment 194341 [details]
Patch v02
Comment 5 Dani Megert CLA 2011-06-06 09:10:12 EDT 
Instead of preventing the item to be added we should simply make it work (like it does for the system editor).

Fix is to make WorkbenchPage.openEditorFromDescriptor(IEditorInput, IEditorDescriptor, boolean, IMemento) API as laready requested by bug 257515 and then use that method in ReopenEditorMenu.open(EditorHistoryItem).
Comment 6 Lars Vogel CLA 2019-11-14 02:21:10 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.