Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343760

Summary:

[eclipse-build] dropins reconciliation is broken

Product:

[Tools] Linux Tools

Reporter:

Chris Aniszczyk <caniszczyk>

Component:

eclipse-build

Assignee:

Packaging Tools Inbox <linux.packagingtools-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

critical

Priority:

CC:

overholt

Version:

unspecified

Target Milestone:

0.7.1

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
c1ddf42963c9be07cf85823eb78680c56f66f10c.patch	none
b1a29747cdef38c5b771386d826c6f24bba03768.patch	none

Description Chris Aniszczyk

2011-04-25 14:20:10 EDT

At the moment, dropins reconciliation isn't working properly because when we build the SDK, we run the equinox initializer after having the JDT/SDK in the dropins directory. This breaks folks who ship just the platform and not the JDT or SDK.

This is related to Red Hat bug:

https://bugzilla.redhat.com/show_bug.cgi?id=665249

Comment 1 Chris Aniszczyk

2011-04-25 14:22:02 EDT

To verify that this occurs, simply run eclipse-build with this parameter...

ant -DdestDir=/some/path -Dprefix=/usr -Dmultilib=true installSDKinDropins

You'll notice that the bundles.info and eclipse profile metadata contain information about JDT and PDE when they should only contain information about the platform.

Comment 2 Chris Aniszczyk

2011-04-25 14:40:20 EDT

Created attachment 194012 [details]
c1ddf42963c9be07cf85823eb78680c56f66f10c.patch

This patch simply runs the initializer before copying what is contained in the dropins directory.

Comment 3 Andrew Overholt

2011-04-25 14:43:58 EDT

I think we were(In reply to comment #2)
> Created attachment 194012 [details]
> c1ddf42963c9be07cf85823eb78680c56f66f10c.patch
> 
> This patch simply runs the initializer before copying what is contained in the
> dropins directory.

Thanks for posting the patch, Chris.  I'm probably mis-reading it, but I don't see how we're moving the calling of the initializer .... I just see some copy calls.

Also, I think we've been using cp directly instead of the ant copy task because the latter wasn't maintaining permissions properly.  Maybe it's now fixed in 1.8.x?

Comment 4 Chris Aniszczyk

2011-04-25 14:48:13 EDT

Good point. I'm pretty sure the file permission issue with Ant hasn't changed.

Comment 5 Chris Aniszczyk

2011-04-25 15:06:12 EDT

Created attachment 194015 [details]
b1a29747cdef38c5b771386d826c6f24bba03768.patch

An updated patch that uses rsync instead.

Comment 6 Andrew Overholt

2011-04-25 15:18:48 EDT

(In reply to comment #5)
> Created attachment 194015 [details]
> b1a29747cdef38c5b771386d826c6f24bba03768.patch
> 
> An updated patch that uses rsync instead.

Using rsync is fine (I've added it to http://wiki.eclipse.org/Linux_Tools_Project/Eclipse_Build#Prerequisites_for_building_with_eclipse-build and confirmed with the Debian guys that they're okay with it.

I see now how you're "moving" the initialization to before the copying of dropins.  I like it.

+1 go ahead and commit.

Comment 7 Chris Aniszczyk

2011-04-25 17:49:35 EDT

Fixed with 074773feb001e726bbf254a61b68e47c5a8b5c05.