| Summary: | 'Run on Server' launch shortcut shows up everywhere | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Michael Rennie <Michael_Rennie> | ||||||||
| Component: | wst.server | Assignee: | Angel Vera <arvera> | ||||||||
| Status: | NEW --- | QA Contact: | Angel Vera <arvera> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P2 | CC: | eclipse.dserodio, kaloyan, psrna, shr31223, silviya, stephan.herrmann, wst.server-inbox | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | Future | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | 338576 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Rennie
Created attachment 194003 [details]
update
or...you could consider the patch that does *not* have a copy/paste error in it
erm, I meant to reference bug 343751. The fix seems a little pessimistic. After the patch I can't see the Run On Server in some of the typical places, like: - Top level of WebProject - Selecting Servlet inside a WebProject (from any perspective) is there a better suggestion? Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. If we don't do this changes the 'Run On Server' action will show for a lot of invalid cases Is there a work-around? If so, why do you believe the work-around is insufficient? No How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manual testing using java projects, and Web projects. Give a brief technical overview. Who has reviewed this fix? Elson What is the risk associated with this fix? Low Created attachment 196044 [details]
v2.0
We could do a force activation, but thinking about it might be better for us to understand what is the better behaviour here.
A- If loading the plugins .ui and all of its extensions through the property tester loading the modules(which requires modules factories), OR
B- showing the RoS and then defaulting to unavailable for the the resource.
I rather give it a little more thinking and hold on to next week, since if this was broken from 324, and no one has complaint so far.
Moving out of 3.3 as we are almost done with it. Marking for future until we have a more accurate time when we can work on this. Dupe of bug 337703 ? (In reply to Angel Vera from comment #6) > I rather give it a little more thinking and hold on to next week, since if > this was broken from 324, and no one has complaint so far. Just for the record - one more complain about this. It is really annoying and confusing to user to see this action in places it is not expected. *** Bug 457124 has been marked as a duplicate of this bug. *** This is here forever, any news on this bug? It might not be critical, but still seeing it for 5 years is somewhat annoying. Another aspect of showing up too much: unlike other launch configuration types, "Run on Server" cannot be disabled in the preferences at
Run/Debug > Launching > Launch Configurations
> Filter checked launch configuration types
In terms of good Eclipse citizenship, *every* launch configuration type should support filtering.
I ran into this when I installed some WTP components only for their editing support, I never intend to run any servers inside the IDE. I had to deinstall Eclipse Web Developer Tools in order to get rid of the undesired option under "Run as...", but there should be a less drastic way to achieve this.
Cc:ing the project inbox, because I see the assignee Angel Vera under "Historical Committers".
|