Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343735

Summary: Consider to use more fine-grained locking
Product: [RT] RAP Reporter: RĂ¼diger Herrmann <ruediger.herrmann>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: ggb667
Version: unspecified   
Target Milestone: 3.1 M5   
Hardware: All   
OS: All   
Whiteboard:

Description RĂ¼diger Herrmann CLA 2011-04-25 10:26:48 EDT
In order to make critical sections thread safe, we currently lock access using single synchronized blocks for read and write access. Performance in these areas could benefit from differenciating between read and write access and use distinct locks.
If it turns out that performce gains can be made, I see two options:
* org.eclipse.equinox.registry has an internal ReadWriteMonitor that we could adopt
* Java 1.5 provides the ReentrantReadWriteLock (depends on bug bug 340310)
Comment 1 Greg Bishop CLA 2013-06-24 09:34:54 EDT
Q: Could you also please consider making is so the editors themselved son't block at all, perhpas by giving them a seperate thread so the user can save and edit files without ever waiting on the IDE?
Comment 2 Ivan Furnadjiev CLA 2016-03-01 04:38:25 EST
The ReentrantReadWriteLock has been used in the most sensitive place with change https://git.eclipse.org/r/#/c/63150/.