Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343725

Summary: CTRL+S not working under certain circumstances on 4.1-I builds
Product: z_Archived Reporter: Thomas Schindl <tom.schindl>
Component: WindowBuilderAssignee: Alexander Mitin <Alexander.Mitin>
Status: CLOSED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: clayberg, remy.suen
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Thomas Schindl CLA 2011-04-25 09:29:36 EDT 
All in all WBW for 3.7 works like a charme in 4.1 but I found one small glitch when using it to design Swing-UIs. 

It somehow looks as focus control is not returned appropriately to the workbench and so the Display-Filter installed in SWT to trigger editor saving is informed about keypresses:

I can reproduce this behavior like this:
* Create a new Swing Designer > JPanel
* CMD+S
* Add a new button to the panel
* CMD+S
* Rename the Button Variable e.g. to test
* Click "Convert Local to Field"
* CMD+S ====> Nothing happens

The same sequence works when design a SWT-UI so I think it has something to with the Swing-Event loop which is eating the events before SWT and so SWT is not seeing them.

The relavante points in Eclipse 4.x sources are found in:
* org.eclipse.e4.ui.bindings/org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.KeyDownFilter which is never executed in the above test case
Comment 1 Alexander Mitin CLA 2011-05-02 16:20:33 EDT 
I followed the steps you've provided and cannot reproduce the behaviour you've described.
The only difference between 3.6 & 4.1 I can see is that in 4.1 it doesn't deactivate the property editor on save. But it doesn't make any sense since it deactivated then on focus lost while pressing 'convert local/field' action button.

You didn't specify which version of the designer you're using, it could be useful to try with latest beta.
Comment 2 Thomas Schindl CLA 2011-05-05 03:59:14 EDT 
I used the latest version from your update-site and one of the latest i-builds available by then? Did you tried it on OS-X?
Comment 3 Alexander Mitin CLA 2011-05-05 10:49:16 EDT 
Yes, I've tried it on OSX 10.6.7 with latest build.