| Summary: | [1.7] Adjust subclasses of AllocationExpression for <> support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Srikanth Sankaran <srikanth_sankaran> | ||||||
| Component: | Core | Assignee: | Satyam Kandula <satyam.kandula> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | satyam.kandula, stephan.herrmann | ||||||
| Version: | 3.7 | Flags: | srikanth_sankaran:
review+
|
||||||
| Target Milestone: | 3.7.1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Srikanth Sankaran
I will look into this. Created attachment 196413 [details]
A Patch
This patch fixes the selection problems, but code snippet evaluator still has problems. CodeSnippetAllocationExpression overrides AllocationExpression#resolvedType and this function has to take care of the new changes that has happened. I am currently looking into it.
Created attachment 196426 [details]
Proposed patch + regression tests
I missed out the changes in SelectionParser in my last patch :(
This patch also fixes the problem in code snippet processing also - some more testing need to be done here.
All tests pass. Srikanth, Please review. Patch looks good to me. Srikanth found one problem while trying to call the constructor of an inner class of a parameterized outer type through the display view. This happens even without diamond case and happens on older versions also and hence filed 347274 to track that. Thanks Srikanth for the review. Released the patch in the Java7 branch Verified using patch feature 1.0.0-20110623-0900 |