Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343669

Summary: Compile error in WorkspaceRunner using post-M7 Eclipse platform
Product: [WebTools] Java Server Faces Reporter: Gerry Kessler <gerry.kessler>
Component: JSF ToolsAssignee: Gerry Kessler <gerry.kessler>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cbridgha, david_williams, raghunathan.srinivasan
Version: 3.3Flags: david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
raghunathan.srinivasan: review+
Target Milestone: 3.3 M7   
Hardware: PC   
OS: Windows XP   
See Also: https://git.eclipse.org/r/114284
https://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=2d40940309c76dd8876ded276786a8f95d563290
Whiteboard: PMC_approved
Attachments:
Description Flags
Comments out overridden method none

Description Gerry Kessler CLA 2011-04-22 16:21:49 EDT 
The Eclipse Platform/Orbit bundle for post-Indigo M7 includes JUnit 4.8.2 whereas M7 and earlier included JUnit 4.8.1.   jsf.util.WorkspaceRunner subclasses BlockJUnit4ClassRunner and injects a MethodRule by overriding a protected method on the superclass. That method has dissappeared in 4.8.2 and is causing a compile error.
Comment 1 Gerry Kessler CLA 2011-04-22 16:53:59 EDT 
Created attachment 193947 [details]
Comments out overridden method
Comment 2 Gerry Kessler CLA 2011-04-22 16:56:25 EDT 
The attached patch eliminates the compile error.  However, it alos makes the class inoperable.   However, there are no classes as part of the WTP Test build that makes use of this class. 

Renablement of this class is tracked by Bug 343672.
Comment 3 Raghunathan Srinivasan CLA 2011-04-25 01:42:11 EDT 
I have released the changes to resolve the compile error in the tests.
Comment 4 Raghunathan Srinivasan CLA 2011-04-25 01:42:54 EDT 
Released
Comment 5 Eclipse Genie CLA 2017-12-18 20:17:07 EST 
New Gerrit change created: https://git.eclipse.org/r/114284