| Summary: | [PlatformConfiguration] Handle null URI better | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Karsten Thoms <karsten.thoms> | ||||||
| Component: | Runtime | Assignee: | Karsten Thoms <karsten.thoms> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | trivial | ||||||||
| Priority: | P3 | CC: | Lars.Vogel | ||||||
| Version: | 3.7 | ||||||||
| Target Milestone: | 4.8 M3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||
| See Also: |
https://git.eclipse.org/r/105408 https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=8dd58d2f8117a7969a33083ea4830e2bc038b17c |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 193933 [details]
Screenshot: Debugger #2
New Gerrit change created: https://git.eclipse.org/r/105408 Gerrit change https://git.eclipse.org/r/105408 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=8dd58d2f8117a7969a33083ea4830e2bc038b17c Thanks, Karsten. |
Created attachment 193932 [details] Screenshot: Debugger #1 The constructor PlatformConfiguration(URL) just catches all exceptions with empty catch clause. One obvious exception that can occur is that the URL argument is null. This should be handled better. I usually have an exception breakpoint on NullPointerException and did not expect that it popped up here. The concrete situation was that the code was indirectly called by UpdateHelpManager#createPlatformConfiguration(), which calls the code always with a null URL. See attached screenshots for the debugger.