Bugzilla – Full Text Bug Listing
| Summary: | CharComposite : magic numbers | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Nicolas Bros <nicolas.bros> |
| Component: | EMF-Facet | Assignee: | Nicolas Bros <nicolas.bros> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | emft.facet-inbox, gdupe, nicolas.guyomar |
| Version: | unspecified | Flags: | nicolas.bros:
indigo+
|
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
DEL_KEYCODE, defined as 8, correspond the the "BACKSPACE" key on my keyboard (In reply to comment #1) > DEL_KEYCODE, defined as 8, correspond the the "BACKSPACE" key on my keyboard Ok. So it should be SWT.BS, which is defined as '\b' and which is equal to 8. Fixed in revision 572. CharComposite does not define any constants. This bug can then be closed. |
There are 2 constants defined with magic numbers (127 and 8) in org.eclipse.emf.facet.widgets.celleditors.ecore.composite.CharComposite. 127 corresponds to SWT.DEL, so the SUPPR_KEYCODE ("suppr" is french for "del" by the way) constant can be replaced by SWT.DEL. As for the DEL_KEYCODE, defined as 8, I don't know what it corresponds to, as it is not defined in SWT. Does the keyCode ever take this value?