Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343646

Summary:	[server] Git Push for tags returns wrong result
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Git	Assignee:	Szymon Brandys <Szymon.Brandys>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	janikpiotrek, tomasz.zarna
Version:	0.2	Flags:	Szymon.Brandys: review+ tomasz.zarna: review+
Target Milestone:	0.2
Hardware:	PC
OS:	Windows XP
Whiteboard:	gsoc2011

Description Szymon Brandys

2011-04-22 05:28:33 EDT

Steps:
1) Use HEAD and remote branch that are in sync
2) Add a tag to a commit in HEAD
3) Use Git Push to push the new tag to remote

The result of Git Push operation is UP_TO_DATE what is wrong.

Comment 1 Piotr Janik

2011-06-13 14:54:13 EDT

Fix: https://github.com/pjanik/orion.server/tree/bug343646

Status was checked incorrectly. Any UP_TO_DATE remote ref update status caused a warning. However there can be combination of UP_TO_DATE statues (i.e. related to branch, which is actually up to date) and OK statuses (i.e. related to tags, which were successfully updated). Now OK will be returned in such case. I've also modified a test a little bit.

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.

Comment 2 Tomasz Zarna

2011-06-14 07:24:20 EDT

Looks fine to me.

Comment 3 Szymon Brandys

2011-06-14 07:27:35 EDT

Fixed with f65ec49bb222d42451fef478a1be5c10f656e527.