Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343629

Summary:

'equivalent' links don't work for emf transaction and validation

Product:

[WebTools] WTP Releng

Reporter:

David Williams <david_williams>

Component:

releng

Assignee:

Tran Le <tranle1>

Status:

RESOLVED FIXED

QA Contact:

David Williams <david_williams>

Severity:

normal

Priority:

CC:

cbridgha, neil.hauge

Version:

3.10

Flags:

david_williams: pmc_approved+
david_williams: pmc_approved? (raghunathan.srinivasan)
david_williams: pmc_approved? (naci.dai)
david_williams: pmc_approved? (deboer)
neil.hauge: pmc_approved+
david_williams: pmc_approved? (kaloyan)
cbridgha: pmc_approved+

Target Milestone:

3.10.0

Hardware:

OS:

Linux

Whiteboard:

PMC

Attachments:

Description	Flags
Proposed patch	none

Description David Williams

2011-04-21 20:41:09 EDT

On our downloads page, we have a link, labeled "equivalent", that (normally) point to a general download site for that prereq project ... but, we're getting 404's for emf validation and emf transaction. 

I think we "compute" the link from several variables in our dependencies.properties file. Will need to investigate which are involved.

Comment 1 David Williams

2011-05-25 22:25:55 EDT

I think these are yours Tran? 
(I know its confusing, and poorly documented ... for me too :)

Comment 2 Tran Le

2011-05-25 22:36:41 EDT

Thanks David, I can work on this issue shortly.

Comment 3 Tran Le

2011-05-26 11:17:00 EDT

Created attachment 196671 [details]
Proposed patch

Patch ready for review.

Comment 4 David Williams

2011-05-26 13:16:05 EDT

The patch looks reasonable to try. 

I suggest you release (and update builder tag) when you are ready to try a build (e.g. after RC2 is declared). 

Committing "releng" (by itself) will not trigger a build (unlike the other releng map files) so you may have to 'manually' press the button on CC page to force a rebuild, if no other fixes are being released.

Comment 5 David Williams

2011-05-26 13:23:18 EDT

For completeness, marking for PMC Review. Without this fix to "releng files", we'll have to "manually" fix the PHP files, which is a pain, though we could for final release, if anyone would prefer not to have this change, and then fix after the actual release. But risk is minimal ... no change to effect code. At worst would break build or PHP page in which case it'd be easy to back out. 

(And, only reason there is any uncertainty, is this is the first case of a URL where we have ".../?project=xxxx..." so I think there is some minimal chance something could go wrong with the 'ant replace' substitutions ... but, worth just trying, instead of testing, IMHO.

Comment 6 Tran Le

2011-05-27 17:47:01 EDT

Patch applied and released in RC3.

Comment 7 David Williams

2011-05-28 11:32:45 EDT

Looks great! Thanks Tran. 

And ... now that the link works :) ... makes it more obvious there are some "1.5 versions" being contributed to Indigo (from what I can tell) ... so you may want to work with Diagram Editor team to see if that pre-req should be updated to 1.5 RC1?

Comment 8 Neil Hauge

2011-05-31 10:26:39 EDT

(In reply to comment #7)

> may want to work with Diagram Editor team to see if that pre-req should be
> updated to 1.5 RC1?

I inquired about this last week but have not yet heard back from Stefan.  I'll ping him again if I don't hear anything today.

Comment 9 Neil Hauge

2011-06-01 12:37:53 EDT

(In reply to comment #8)
> (In reply to comment #7)
> 
> > may want to work with Diagram Editor team to see if that pre-req should be
> > updated to 1.5 RC1?
> 
> I inquired about this last week but have not yet heard back from Stefan.  I'll
> ping him again if I don't hear anything today.

Still haven't heard back from Stefan on this issue. I think that as you mentioned before, users will be getting 1.5 when they download from the Indigo repository, so I think we need to upgrade these dependencies to be in line with the Indigo repo.  I'll enter a separate bug for this.