Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343625

Summary:	[client] hook in the directory prompting dialog to file move/copy
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	339145
Bug Blocks:

Description Susan McCourt

2011-04-21 19:26:45 EDT

When bug 339145 is done, we will need to hook this into the move/copy UI.  There is already a menu item for it, but there is further work we will want to do as far as validation goes.

For example, if there is a name collision implied by the move or copy of a file/folder, we'll want to prompt for a rename of the file/folder.  (There is some code like this in navigate-table.js for the copy/paste gesture, we should reuse/move this code).

This would also be a good time to get rid of any redundant code and ensure that all the error messages are reported properly.

Comment 1 Susan McCourt

2011-05-18 19:16:15 EDT

We will also want to reduce the number of precomputed choices in the move/copy menus.  We might just want to show the favorites, maybe parents/siblings.

Comment 2 Susan McCourt

2011-05-26 18:20:51 EDT

I hooked in the dialog and vastly simplified the "compute target menu choices" now that we can use the dialog to get anywhere in the tree.  

I did notice that we aren't reporting errors, so there is still work to be done here.

Comment 3 Susan McCourt

2011-06-02 18:34:20 EDT

(In reply to comment #2)
> I hooked in the dialog and vastly simplified the "compute target menu choices"
> now that we can use the dialog to get anywhere in the tree.  
> 
> I did notice that we aren't reporting errors, so there is still work to be done
> here.

We did not have an errback on the call to the fileClient.  I added one.
However it is not getting called, so I think there is a problem propagating errors happening down below.  I opened bug 348149 and assigned to John.

Closing this bug because the prompter is hooked in and the client code is supplying an errback.  It's possible I'm doing something wrong, but we can follow up on that in bug 348149.