Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343554

Summary:

ICU4J violations

Product:

[Modeling] MoDisco

Reporter:

Nicolas Bros <nicolas.bros>

Component:

Main

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

fabien.giquel, hugo.bruneliere, modisco.web-inbox

Version:

0.9.0

Flags:

nicolas.bros: indigo+

Target Milestone:

0.9.0 M7

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
violations	none

Description Nicolas Bros

2011-04-21 10:33:28 EDT

Created attachment 193833 [details]
violations

I used the tool I just made (Bug 343533) to check for violations to the ICU4J rule related to the simultaneous release requirements (http://wiki.eclipse.org/ICU4J).

It reports 21 violations in MoDisco code (see attached report).

Comment 1 Nicolas Bros

2011-04-29 03:47:29 EDT

I committed fixes in revision 4366.

But there are still these remaining occurrences I'm not sure about:

java.lang.Character : /org.eclipse.gmt.modisco.java.discoverer/src/org/eclipse/gmt/modisco/java/io/library/ClassFileParser.java
java.lang.Character : /org.eclipse.gmt.modisco.java.discoverer/src/org/eclipse/gmt/modisco/java/io/library/ClassFileParser.java
java.lang.Character : /org.eclipse.modisco.java.discoverer/src/org/eclipse/modisco/java/discoverer/internal/io/library/ClassFileParser.java
java.lang.Character : /org.eclipse.modisco.java.discoverer/src/org/eclipse/modisco/java/discoverer/internal/io/library/ClassFileParser.java

Comment 2 Fabien Giquel

2011-04-29 04:09:01 EDT

Hi Nicolas,

org.eclipse.jdt.core API is used in ClassFileParser.java
org.eclipse.jdt.core published API uses java.lang.Character (see IMemberValuePair.K_CHAR). We cannot use icu4j UCharacter using this API.

It will be an exception to the ICU4J requirement.

Comment 3 Nicolas Bros

2011-04-29 04:36:10 EDT

Thanks for your confirmation. I'm marking this bug as fixed.

Comment 4 Hugo Bruneliere

2011-08-18 08:16:13 EDT

Bug solved.