Bugzilla – Full Text Bug Listing
| Summary: | Widget is disposed on close compat editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Thomas Kratz <eiswind> | ||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Eric Moffatt <emoffatt> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | remy.suen | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 4.1 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Thomas Kratz
Was the active part the editor being closed or another part? I can't tell exactly. Will watch this. I once guessed it has to do sth with the toolbars i have in my form page headings. (In reply to comment #2) > I once guessed it has to do sth with the toolbars i have in my form page > headings. It's very likely that that's the cause. Based on the stack trace it seems that the tool bar (of the editor) had focus and then when it got disposed SWT tried to ask the shell to grant focus to one of its controls again. In this loop, it found the editor and tried to ask it to take focus again but by then the part's controls have already been disposed. can we get around this easily ? (In reply to comment #4) > can we get around this easily ? One way to workaround the problem would be to override your editor's setFocus() method. public void setFocus() { for (CTabItem item : getTabFolder().getItems()) { if (item.isDisposed()) { return; } } super.setFocus(); } (In reply to comment #5) > for (CTabItem item : getTabFolder().getItems()) { That wouldn't work. You'd have to use getContainer() then downcast it to a CTabFolder. Thx, I'll give that a try. Created attachment 193877 [details]
ContributedPartRenderer patch v1
We get another activation event during the disposal. At this point, the control has already been disposed by the renderer though it's not technically disposed yet (isDisposed() will return false).
The suggested fix here is to only activate the part of an activated control if it's actually still attached to a model element. Otherwise, we won't react to the SWT activation event.
(In reply to comment #8) > Created attachment 193877 [details] > ContributedPartRenderer patch v1 Patch released to CVS HEAD. The only way I could reproduce the problem (although my trace is slightly different) was to open a PDE editor and then close all the other parts (so now the editor takes up all the space of the workbench window). Then I would use the keyboard to set focus to the form's toolbar and then use Ctrl+W to close. I doubt your scenario was as obscure as this but I believe the patch above should fix the problem for you. In any case, thanks for the bug report as always, Thomas! Verified with I20110426-0200 on Windows XP. |