Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343509

Summary:

External folders project is not created

Product:

[Eclipse Project] JDT

Reporter:

Krzysztof Daniel <krzysztof.daniel>

Component:

Core

Assignee:

Jay Arthanareeswaran <jarthana>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, krzysztof.daniel, Olivier_Thomann, satyam.kandula, srikanth_sankaran

Version:

3.6.2

Flags:

daniel_megert: pmc_approved+

Target Milestone:

3.6.2+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

320618, 337415

Bug Blocks:

340629

Attachments:

Description	Flags
Patch	none
Updated patch	none

Description Krzysztof Daniel

2011-04-21 06:24:35 EDT

Could you please also release the patch in Eclipse 3.6.2+?

+++ This bug was initially created as a clone of Bug #337415 +++

When the preferences and the project are imported using ANT script, the external folders project is not created causing potentially dangerous behavior (f.e. no delta can be computed, so each build is a full build).

The steps to reproduce the behavior are:
1. Import the projects from attached zip file
2. Inside the Data project there are two launch configurations.
3. Execute the "Headless Import"
4. Refresh the Data project. runtimeData folder contains new workspace, check in the .metadata/.plugins/org.eclipse.jdt.core if the external folders project exists.

Two other projects are ant tasks responsible for loading the preferences and importing the project. The second launch configuration ("Verification") launches Eclipse which uses the same workspace as the headless one, so it is possible to check if the classpath variable has been correctly loaded.

Comment 1 Dani Megert

2011-04-21 06:53:09 EDT

(In reply to comment #0)
> Could you please also release the patch in Eclipse 3.6.2+?

Makes sense but I suggest to wait a bit to see how the fix plays in the field.

Comment 2 Dani Megert

2011-07-05 05:50:07 EDT

I guess it's time to backport this now.

Comment 3 Jay Arthanareeswaran

2011-07-06 12:11:31 EDT

Created attachment 199193 [details]
Patch

Patch on R3_6_maintenance branch - includes patches from bug 337415 and bug 320618, which is a prerequisite for the fix.

Comment 4 Jay Arthanareeswaran

2011-07-07 05:51:21 EDT

Tested the patch. The fix is working and the existing tests are passing as well.
Dani, we need PMC approval for this. TIA.

Comment 5 Dani Megert

2011-07-27 05:03:17 EDT

Path is good but the copyright date needs to be updated in all files.

+1 for 3.6.2+.

Comment 6 Dani Megert

2011-07-27 05:03:45 EDT

>Path is good 
Patch is good

Comment 7 Jay Arthanareeswaran

2011-07-27 07:29:38 EDT

Created attachment 200438 [details]
Updated patch

Patch contains updated copyrights.

Comment 8 Jay Arthanareeswaran

2011-07-28 01:14:53 EDT

Released in R3_6_maintenance.